Remove netlify #2681
Merged
Remove netlify #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying decent-interface with
|
| Latest commit: |
dad6866
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://48656dd2.decent-interface.pages.dev |
| Branch Preview URL: | https://remove-netlify.decent-interface.pages.dev |
johnqh
approved these changes
Jan 21, 2025
adamgall
commented
Jan 21, 2025
There was a problem hiding this comment.
This is the only actual code change in this PR. This change happened in the prepare-toasts branch. That branch included this bugfix. The bug is that we were telling ALL TOASTS to dismiss, regardless of where they were initiated. In this specific context we should only be telling the disconnect toast to dismiss.
We also don't need to store the toast id in a ref, as far as i can tell.
mudrila
approved these changes
Jan 21, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest of the stuff needed to fully remove netlify from codebase.
This code is necessary to be included in the next production push, because the Netlify Backends have been fully dismantled already.
The code in this PR is already in
develop, but it's not yet onmain.It's from the following PRs:
developwithout a PR 🫣. it was during the netlify -> cloudflare upgrade and i had to do this right then, i was hotswapping prod ya know)