-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-115]
Fix getting / showing voting weight on NFT DAO proposals
#2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…witch `[Eng 50]` | Dao creation network switch
…abi-decoding `[ENG-86]` Try decoding transactions with `viem`'s `decodeFunctionData` when Safe Decoder fails
Replace hero image with new asset
Fix proposal load bug
…g-icon `[ENG-5]` Fix misaligned toast loading icon
`[ENG-84]` Toast not closing
…y for erc20 proposals
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Fix ugly line under search box
[WIP]
Fix 413 error when creating large roles creation proposal
DarksightKellar
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left a potential reminder
adamgall
approved these changes
Jan 13, 2025
Merged
[ENG-115]
Fix getting / showing voting weight on NFT DAO proposals
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
loadProposalVotingWeight
inProposalSummary
- it was fetching the data correctly only forerc20
proposalsTesting Instructions
Sepolia
with attached NFT which you have in your wallet - so that you have some voting power. Would be ideal if you have couple of them for better validation of voting power displayNOW A HOTFIX
This PR's target branch is being changed from
develop
tohotfix/v0.4.1
. As a result, there are now more code changes in this PR than before.The additional changes include code from these PRs:
[Eng 50]
| Dao creation network switch #2645[ENG-86]
Try decoding transactions withviem
'sdecodeFunctionData
when Safe Decoder fails #2649[ENG-5]
Fix misaligned toast loading icon #2651[ENG-84]
Toast not closing #2657