Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-115] Fix getting / showing voting weight on NFT DAO proposals #2661

Merged
merged 33 commits into from
Jan 13, 2025

Conversation

mudrila
Copy link
Contributor

@mudrila mudrila commented Jan 10, 2025

Changes

  • Fix loadProposalVotingWeight in ProposalSummary - it was fetching the data correctly only for erc20 proposals

Testing Instructions

  1. Create NFT Voting DAO on Sepolia with attached NFT which you have in your wallet - so that you have some voting power. Would be ideal if you have couple of them for better validation of voting power display
  2. Create any proposal on that DAO (changing DAO name / Snapshot ENS / Doing Transfer)
  3. Make sure you can view the proposal (this was a problem previously)
  4. Make sure you can vote on the proposal (this was an issue previously as well)

NOW A HOTFIX

This PR's target branch is being changed from develop to hotfix/v0.4.1. As a result, there are now more code changes in this PR than before.

The additional changes include code from these PRs:

Da-Colon and others added 22 commits December 20, 2024 10:22
…witch

`[Eng 50]` | Dao creation network switch
…abi-decoding

`[ENG-86]` Try decoding transactions with `viem`'s `decodeFunctionData` when Safe Decoder fails
Replace hero image with new asset
…g-icon

`[ENG-5]` Fix misaligned toast loading icon
@mudrila mudrila self-assigned this Jan 10, 2025
@mudrila mudrila added the bug Something isn't working label Jan 10, 2025
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit c938649
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/6781c56657fec400081f7314
😎 Deploy Preview https://deploy-preview-2661.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Jan 10, 2025

Deploying decent-interface with  Cloudflare Pages  Cloudflare Pages

Latest commit: c938649
Status:🚫  Build failed.

View logs

@mudrila mudrila changed the title [WIP] Fix 413 error when creating large roles creation proposal Fix getting / showing voting weight on NFT DAO proposals Jan 10, 2025
@mudrila mudrila requested review from adamgall and johnqh January 10, 2025 20:15
@mudrila mudrila marked this pull request as ready for review January 10, 2025 20:16
Copy link
Contributor

@DarksightKellar DarksightKellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a potential reminder

src/components/Proposals/ProposalSummary.tsx Show resolved Hide resolved
@adamgall adamgall changed the base branch from develop to hotfix/v0.4.2 January 13, 2025 18:29
@adamgall adamgall changed the base branch from hotfix/v0.4.2 to develop January 13, 2025 18:30
@adamgall adamgall changed the base branch from develop to hotfix/v0.4.2 January 13, 2025 18:30
@adamgall adamgall merged commit e6a5303 into hotfix/v0.4.2 Jan 13, 2025
7 of 8 checks passed
@adamgall adamgall deleted the fix/content-is-too-large branch January 13, 2025 19:40
@adamgall adamgall mentioned this pull request Jan 13, 2025
@mudrila mudrila changed the title Fix getting / showing voting weight on NFT DAO proposals [ENG-115] Fix getting / showing voting weight on NFT DAO proposals Jan 13, 2025
Copy link

linear bot commented Jan 13, 2025

Copy link

sentry-io bot commented Jan 16, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ContractFunctionExecutionError: The contract function "balanceOf" returned no data ("0x"). //proposals/:proposalId View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants