-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix proposal load bug #2652
Fix proposal load bug #2652
Conversation
✅ Deploy Preview for decent-interface-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes are looking good
Vanta DAO is indeed ERC-721 DAO, I can confirm
@DarksightKellar you're able to check the type and state of Vanta DAO & their proposals onchain right? Here's how I would do it
|
This PR fixes a bug that was preventing VantaDAO from loading. The fix is in
src/utils/azorius.ts
, where the wrong strategy contract appears to have been used to callgetProposalVotes
.Need confirmation on the true type of VantaDAO. If it's an ERC-721 type and has just one proposal, all is good.
If not, well. We have a problem on our hands here.
Testing