Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proposal load bug #2652

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Fix proposal load bug #2652

merged 3 commits into from
Jan 7, 2025

Conversation

DarksightKellar
Copy link
Contributor

@DarksightKellar DarksightKellar commented Jan 7, 2025

This PR fixes a bug that was preventing VantaDAO from loading. The fix is in src/utils/azorius.ts, where the wrong strategy contract appears to have been used to call getProposalVotes.

Need confirmation on the true type of VantaDAO. If it's an ERC-721 type and has just one proposal, all is good.

If not, well. We have a problem on our hands here.

Testing

Copy link

linear bot commented Jan 7, 2025

Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for decent-interface-dev ready!

Name Link
🔨 Latest commit 5a04004
🔍 Latest deploy log https://app.netlify.com/sites/decent-interface-dev/deploys/677d3aa5a4852300089b976d
😎 Deploy Preview https://deploy-preview-2652.app.dev.decentdao.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DarksightKellar DarksightKellar requested review from mudrila, Da-Colon, adamgall and johnqh and removed request for mudrila January 7, 2025 14:38
Copy link
Contributor

@mudrila mudrila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes are looking good
Vanta DAO is indeed ERC-721 DAO, I can confirm

@adamgall
Copy link
Member

adamgall commented Jan 7, 2025

@DarksightKellar you're able to check the type and state of Vanta DAO & their proposals onchain right?

Here's how I would do it

  • pull up Vanta DAO in Safe UI
  • Check installed Modules in Safe UI
  • Load up that (those) module address(es) in Etherscan
  • Confirm that Azorius is present, what its current proposal count is at, etc
  • Get the installed strategy addresses
  • Load those in Etherscan to see what type it is / they are

@mudrila mudrila merged commit 1f083d1 into develop Jan 7, 2025
7 checks passed
@mudrila mudrila deleted the eng-93-fix-proposal-load branch January 7, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants