Skip to content

Commit

Permalink
test/system: Properly bail-out if failed to cache images
Browse files Browse the repository at this point in the history
The 'die' function is a remnant from times before the system tests
rewrite. It served for writing an error message and then failing
the test. Since the rewrite it is no longer present. Instead, simply
use 'false' in case a caching step fails.

Fallout from da6b6a7

containers#899
  • Loading branch information
HarryMichal committed Dec 4, 2021
1 parent b14d623 commit ae8bd1a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/system/000-setup.bats
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ load 'libs/helpers'
@test "test suite: Setup" {
_setup_environment
# Cache the default image for the system
_pull_and_cache_distro_image $(get_system_id) $(get_system_version) || die
_pull_and_cache_distro_image $(get_system_id) $(get_system_version) || false
# Cache all images that will be needed during the tests
_pull_and_cache_distro_image fedora 32 || die
_pull_and_cache_distro_image busybox || die
_pull_and_cache_distro_image fedora 32 || false
_pull_and_cache_distro_image busybox || false
}

0 comments on commit ae8bd1a

Please sign in to comment.