test/system: Test startup on Rawhide with supported versions #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarryMichal
added
3. Enhancement
|
Build failed.
|
HarryMichal
force-pushed
the
test/fedora-previous-versions
branch
2 times, most recently
from
5ce4c6a to
a516f3a
Compare
|
Build succeeded.
|
HarryMichal
force-pushed
the
test/fedora-previous-versions
branch
from
a516f3a to
a3a1867
Compare
|
Build failed.
|
HarryMichal
force-pushed
the
test/fedora-previous-versions
branch
2 times, most recently
from
dfb9312 to
e1dd399
Compare
|
Build succeeded.
|
|
Do we want the test to be only for Fedora Rawhide or should I adjust it even for older releases? The bottom limit would still be the "eldest" supported release. |
HarryMichal
force-pushed
the
test/fedora-previous-versions
branch
from
e1dd399 to
b402f11
Compare
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
Oct 22, 2021
We need to know if the latest changes in the libc (that is dynamically linked to the binary) causes problems in containers based on older releases of Fedora. The estimate of the version numbers ís very crude and does not follow the upstream schedule. That should not be a problem. A part of an existing test has been reused an made into a helper function to implement this. containers#899
HarryMichal
force-pushed
the
test/fedora-previous-versions
branch
from
b402f11 to
fda018d
Compare
|
Build succeeded.
|
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
Nov 9, 2021
The 'die' function is a remnant from times before the system tests rewrite. It served for writing an error message and then failing the test. Since the rewrite it is no longer present. Instead, simply use 'false' in case a caching step fails. Fallout from da6b6a7 containers#899
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
Nov 9, 2021
We need to know if the latest changes in the libc (that is dynamically linked to the binary) causes problems in containers based on older releases of Fedora. The estimate of the version numbers ís very crude and does not follow the upstream schedule. That should not be a problem. A part of an existing test has been reused an made into a helper function to implement this. containers#899
HarryMichal
force-pushed
the
test/fedora-previous-versions
branch
from
fda018d to
da7ec24
Compare
Let's stick to Rawhide for now as it is the main motivation behind this test and other releases may be added in the future. |
HarryMichal
added a commit
to HarryMichal/toolbox
that referenced
this pull request
Nov 9, 2021
We need to know if the latest changes in the libc (that is dynamically linked to the binary) causes problems in containers based on older releases of Fedora. The estimate of the version numbers is very crude and does not follow the upstream schedule. That should not be a problem, though. A part of an existing test has been reused and made into a helper function to implement this. containers#899
HarryMichal
force-pushed
the
test/fedora-previous-versions
branch
from
da7ec24 to
b6618a0
Compare
|
Build failed.
|
|
This slowness on Rawhide is making me angry. |
The 'die' function is a remnant from times before the system tests rewrite. It served for writing an error message and then failing the test. Since the rewrite it is no longer present. Instead, simply use 'false' in case a caching step fails. Fallout from da6b6a7 containers#899
We need to know if the latest changes in the libc (that is dynamically linked to the binary) causes problems in containers based on older releases of Fedora. The estimate of the version numbers is very crude and does not follow the upstream schedule. That should not be a problem, though. A part of an existing test has been reused and made into a helper function to implement this. This increases the run time of the test suite on Rawhide which already takes longer than the same test suite on released versions of Fedora. Make up for it by increasing the timeout by 2 minutes. containers#899
HarryMichal
force-pushed
the
test/fedora-previous-versions
branch
from
b6618a0 to
874bdaa
Compare
|
Build failed.
|
debarshiray
reviewed
Dec 7, 2021
There was a problem hiding this comment.
Thanks for the new test.
This line in the commit message made me curious:
The estimate of the version numbers is very crude and does not follow
the upstream schedule. That should not be a problem, though.
Why is it crude? How does it not follow the upstream schedule? And why it shouldn't be a problem? :)
Are you referring to how we are testing N, N-1 and N-2 (where N is the version of Rawhide)?
| local os_release="$(find_os_release)" | ||
| local system_id="$(get_system_id)" | ||
| local system_version="$(get_system_version)" | ||
| local rawhide_res="$(awk '/rawhide/' $os_release)" |
There was a problem hiding this comment.
I am curious. Can't we just use grep? It's easier to understand than awk.
debarshiray
reviewed
Dec 7, 2021
There was a problem hiding this comment.
Seems like there's no commit da6b6a7c5a6e5e284e6642c29159a872ceec94e2:
[rishi@kolache toolbox]$ git show da6b6a7c5a6e5e284e6642c29159a872ceec94e2
fatal: bad object da6b6a7c5a6e5e284e6642c29159a872ceec94e2
I suppose it's meant to be 54a2ca1
Yes, that's exactly it. |
Ah, snap. Seems like I mistakenly pointed that to my fork :/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to know if the latest changes in the libc (that is dynamically
linked to the binary) causes problems in containers based on older
releases of Fedora.
The estimate of the version numbers ís very crude and does not follow
the upstream schedule. That should not be a problem.
A part of an existing test has been reused an made into a helper
function to implement this.