Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor xhgui launch command #31

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Refactor xhgui launch command #31

merged 2 commits into from
Jun 4, 2024

Conversation

tyler36
Copy link
Collaborator

@tyler36 tyler36 commented May 28, 2024

DDEV introduced a way to reduce "launch" comand boilerplate using a port. ddev/ddev#6024

This PR takes advantage of that, and reduces the laucnh down to a simple "port" implementation.

We'll need require DDEV 1.23 (?) during install.
This is considered a breaking change and will require a point release.

@tyler36
Copy link
Collaborator Author

tyler36 commented May 30, 2024

What is the recommended way to check for DDEV version for this PR?

The add-on-template uses ddev debug capabilities

$ ddev debug capabilities
multiple-dockerfiles
interactive-project-selection
ddev-get-yaml-interpolation
config-star-yaml-merging
pre-dockerfile-insertion
user-env-var
npm-yarn-caching
exposed-ports-configuration
daemon-run-configuration
get-volume-db-version
migrate-database
web-start-hooks
add-on-versioning
multiple-upload-dirs
debian-bookworm
corepack

But I'm not sure this is a "feature". Does bash has native support for parsing a string as a version number for comparison?

@rfay
Copy link
Member

rfay commented May 30, 2024

Why not just use ddev_version_constraint in config.xhgui.yaml? That might the best.

ddev/ddev-platformsh uses the capabilities technique, https://github.com/ddev/ddev-platformsh/blob/main/install.yaml#L23

SOMEWHERE I have a bash function for comparing version.
The only one I can find right now is:

https://github.com/ddev/ddev/blob/6e82ece9e371e9e4a54bcbe4495b1aab52eb39c3/.buildkite/sanetestbot.sh#L13

@tyler36
Copy link
Collaborator Author

tyler36 commented May 30, 2024

Seems like corepack was also introduced in 1.23 so I'm using that in the pre_install_actions.

@tyler36 tyler36 marked this pull request as ready for review May 30, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants