Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: ddev solr-admin command #41

Open
5 tasks
gitressa opened this issue Jun 5, 2024 · 4 comments
Open
5 tasks

Feature request: ddev solr-admin command #41

gitressa opened this issue Jun 5, 2024 · 4 comments

Comments

@gitressa
Copy link
Contributor

gitressa commented Jun 5, 2024

Feature request

Wouldn't it be great if ddev solr-admin launched the new default Solr over HTTPS? ddev launch :8943 is less intuitive, nor rememberable ...

Describe your solution

  • Make ddev solr-admin launch Solr over HTTPS at https://project.ddev.site:8943/
  • Under ddev describe
    • Capitalize and use "Solr", same as for "Mailpit"
    • Add ddev solr-admin under "Solr"
    • Add user and password info under INFO column
$ ddev describe
┌─────────────────────────────────────────────────────────────────────────────────────────┐
│ Project: solr-test ~/dev/solr-test https://solr-test.ddev.site                          │
│ Docker platform: linux-docker                                                           │
│ Router: traefik                                                                         │
├──────────┬──────┬─────────────────────────────────────────────────┬─────────────────────┤
│ SERVICE  │ STAT │ URL/PORT                                        │ INFO                │
├──────────┼──────┼─────────────────────────────────────────────────┼─────────────────────┤
[... ]
├──────────┼──────┼─────────────────────────────────────────────────┼─────────────────────┤
│ Solr     │ OK   │ https://solr-test.ddev.site:8943                │ User: solr          │
│          │      │ InDocker: solr:8983,8983                        │ Password: SolrRocks │
│          │      │ ddev solr-admin                                 │                     │
├──────────┼──────┼─────────────────────────────────────────────────┼─────────────────────┤
│ Mailpit  │      │ Mailpit: https://solr-test.ddev.site:8026       │                     │
│          │      │ `ddev mailpit`                                  │                     │
├──────────┼──────┼─────────────────────────────────────────────────┼─────────────────────┤

PS. Perhaps `ddev mailpit` should be just ddev mailpit?

Related issue

@gitressa gitressa changed the title Feature request: ddev solr command Feature request: `ddev solr command Jun 5, 2024
@gitressa gitressa changed the title Feature request: `ddev solr command Feature request: ddev solr command Jun 5, 2024
@mkalkbrenner
Copy link
Collaborator

Wouldn't it be great if ddev solr launched the #27? ddev launch :8943 is less intuitive, nor rememberable ...

I don't understand that request.
ddev solr just makes the solr command line tool available as it is. Even if it can start or stop solr, it shouldn't be used for that in ddev. We can't turn off these specific options. But other commands of that client are useful and that's why it is available, for example to create collections ore cores.

@stasadev
Copy link
Member

stasadev commented Jun 5, 2024

@gitressa,

ddev solr is already used to run solr itself, so I would use another name like ddev solr-admin or ddev solr-ui.

The feature is quite simple, you can create a PR for it based on:

@gitressa
Copy link
Contributor Author

gitressa commented Jun 5, 2024

Thanks for fast answers and suggesting alternative commands. Perhaps ddev solr-admin is best? I'll update the issue summary and title.

@gitressa gitressa changed the title Feature request: ddev solr command Feature request: ddev solr-admin command Jun 5, 2024
@gitressa
Copy link
Contributor Author

gitressa commented Jun 5, 2024

PS. I created ddev/ddev#6276 about `ddev mailpit`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants