-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ct 177/part2 format code over #108
Merged
VersusFacit
merged 9 commits into
CT-177/add_precommit_hooks
from
CT-177/part2_format_code_over
Mar 29, 2022
Merged
Ct 177/part2 format code over #108
VersusFacit
merged 9 commits into
CT-177/add_precommit_hooks
from
CT-177/part2_format_code_over
Mar 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add contributing.md to snowflake repo * go through a round of updates * expand test examples, reword for clarity, and run spelling/grammar checks * reword couple of things for clarity Co-authored-by: Mila Page <[email protected]>
Co-authored-by: Mila Page <[email protected]> Authored-by: Josh Taylor <[email protected]>
jtcohen6
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One teensy comment, unrelated to the actual thrust of this PR. Otherwise LGTM
* Bumping version to 1.1.0b1 * changelog update * file name change Co-authored-by: Github Build Bot <[email protected]> Co-authored-by: Matthew McKnight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #95
Description
The second half of #107
Formatting the rest of the repo with the new code changes introduced. Separated out for ease of reading.
Checklist
CHANGELOG.md
and added information about my change to the "dbt-snowflake next" section.