Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ct 177/part2 format code over #108

Merged
merged 9 commits into from
Mar 29, 2022

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Mar 14, 2022

partially addresses #95

Description

The second half of #107

Formatting the rest of the repo with the new code changes introduced. Separated out for ease of reading.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-snowflake next" section.

@VersusFacit VersusFacit self-assigned this Mar 14, 2022
@cla-bot cla-bot bot added the cla:yes label Mar 14, 2022
@VersusFacit VersusFacit changed the base branch from main to CT-177/add_precommit_hooks March 14, 2022 01:17
@VersusFacit VersusFacit mentioned this pull request Mar 14, 2022
4 tasks
@VersusFacit VersusFacit requested a review from jtcohen6 March 14, 2022 01:24
McKnight-42 and others added 2 commits March 13, 2022 19:55
* add contributing.md to snowflake repo
* go through a round of updates
* expand test examples, reword for clarity, and run spelling/grammar checks
* reword couple of things for clarity

Co-authored-by: Mila Page <[email protected]>
Co-authored-by: Mila Page <[email protected]>
Authored-by: Josh Taylor <[email protected]>
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One teensy comment, unrelated to the actual thrust of this PR. Otherwise LGTM

.github/workflows/stale.yml Outdated Show resolved Hide resolved
@VersusFacit VersusFacit merged commit dadbd42 into CT-177/add_precommit_hooks Mar 29, 2022
@VersusFacit VersusFacit deleted the CT-177/part2_format_code_over branch March 29, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants