Ct 177/add precommit hooks #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding precheck manager, make tasks, workflows, and dev requirements to facilitate these workflows.
VersusFacit
commented
Mar 13, 2022
| # of our control to the mix. Unfortunately, there's nothing we can | ||
| # do about per pre-commit's author. | ||
| # See https://github.com/pre-commit/pre-commit/issues/730 for details. | ||
| args: [--show-error-codes, --ignore-missing-imports] |
There was a problem hiding this comment.
Added the --ignore-missing-imports flag here to reduce in-code clutter. My argument is that all these errors tell you is that the upstream project lacks static type information, which isn't that powerful of knowledge.
VersusFacit
commented
Mar 13, 2022
| @@ -18,10 +18,10 @@ | |||
| InternalException, RuntimeException, FailedToConnectException, | |||
| DatabaseException, warn_or_error | |||
| ) | |||
| from dbt.adapters.base import Credentials | |||
| from dbt.adapters.base import Credentials # type: ignore | |||
There was a problem hiding this comment.
attr-defined errors are masked by this # type: ignore declaration
4 tasks
gshank
requested changes
Mar 15, 2022
jtcohen6
approved these changes
Mar 23, 2022
* use checks over code and rewrite repo to conform to style conventions * Add query_id to adapter payload and tests. (#109) * Mix in released snowflake 1.1.0b1 * Resolve a Black library issue
VersusFacit
commented
Mar 29, 2022
| rev: 21.12b0 | ||
| hooks: | ||
| - id: black | ||
| additional_dependencies: ['click==8.0.4'] |
There was a problem hiding this comment.
gshank
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #95
Description
Adds precommit hooks and tooling (e.g. a handy makefile) for this repo. A few additions to files that don't really address core logic.
Wait, why review this if it isn't passing?
This PR won't pass until we merge in all the little whitespace formatting code changes. I have those over in PR 108. The proper merge order:
1. approval of this PR (107) 🔴2. approval of PR 108 🟢3. merge 108 to make this PR 🟢4.
Background thinking
Why these changes?
dbtif we wanted static analysis in this repository)Checklist
CHANGELOG.mdand added information about my change to the "dbt-snowflake next" section.