Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating set-output #450

Merged
merged 2 commits into from
May 16, 2023
Merged

updating set-output #450

merged 2 commits into from
May 16, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented May 15, 2023

resolves #250

Description

Fixes last remaining instances of set-output.

Checklist

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label May 15, 2023
@emmyoop emmyoop requested a review from a team as a code owner May 15, 2023 20:26
@emmyoop emmyoop requested a review from Fleid May 15, 2023 20:26
@cla-bot cla-bot bot added the cla:yes label May 15, 2023
@emmyoop emmyoop requested review from mikealfare, a team, aranke and davidbloss and removed request for a team and Fleid May 15, 2023 20:26
davidbloss
davidbloss approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@davidbloss davidbloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

McKnight-42
McKnight-42 approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes seem straight forward should be good to merge once tests all pass

@emmyoop
Copy link
Member Author

emmyoop commented May 16, 2023

retrigger CI

@emmyoop emmyoop closed this May 16, 2023
@emmyoop emmyoop reopened this May 16, 2023
@emmyoop emmyoop merged commit 272a19e into main May 16, 2023
@emmyoop emmyoop deleted the er/set-output-instances branch May 16, 2023 15:07
emmyoop added a commit that referenced this pull request May 16, 2023
@emmyoop
updating set-output (#450)
57a5276 
* updating set-output

* add back run, move comment
emmyoop added a commit that referenced this pull request May 16, 2023
@emmyoop
updating set-output (#450)
e1f6a94 
* updating set-output

* add back run, move comment
emmyoop added a commit that referenced this pull request May 16, 2023
@emmyoop
updating set-output (#450)
ccd4c52 
* updating set-output

* add back run, move comment
emmyoop added a commit that referenced this pull request May 16, 2023
@emmyoop
updating set-output (#450)
0a0af09 
* updating set-output

* add back run, move comment
emmyoop added a commit that referenced this pull request May 16, 2023
@emmyoop
updating set-output (#450)
912ee82 
* updating set-output

* add back run, move comment
emmyoop added a commit that referenced this pull request May 16, 2023
@emmyoop
updating set-output (#450)
9e17fa4 
* updating set-output

* add back run, move comment
nathaniel-may pushed a commit that referenced this pull request May 16, 2023
@emmyoop @davidbloss
[Backport] 1.1.latest gh deprecations (#444)
63ae6f4 
* update used gh actions ahead of set-output, node12 deprecation (#418)

* updating set-output (#450)

* updating set-output

* add back run, move comment

---------

Co-authored-by: David Bloss <[email protected]>
nathaniel-may pushed a commit that referenced this pull request May 16, 2023
@emmyoop @davidbloss
[Backport] 1.2.latest gh deprecations (#448)
dcdfb1f 
* update used gh actions ahead of set-output, node12 deprecation (#418)

* updating set-output (#450)

* updating set-output

* add back run, move comment

---------

Co-authored-by: David Bloss <[email protected]>
nathaniel-may pushed a commit that referenced this pull request May 16, 2023
@emmyoop @davidbloss
[Backport] 1.3.latest gh deprecations (#445)
02bca0c 
* update used gh actions ahead of set-output, node12 deprecation (#418)

* updating set-output (#450)

* updating set-output

* add back run, move comment

---------

Co-authored-by: David Bloss <[email protected]>
nathaniel-may pushed a commit that referenced this pull request May 16, 2023
@emmyoop @davidbloss
[Backport] 1.4.latest gh deprecations (#446)
973f72b 
* update used gh actions ahead of set-output, node12 deprecation (#418)

* updating set-output (#450)

* updating set-output

* add back run, move comment

---------

Co-authored-by: David Bloss <[email protected]>
nathaniel-may pushed a commit that referenced this pull request May 16, 2023
@emmyoop @davidbloss
[Backport] 1.5.latest gh deprecations (#447)
0302a06 
* update used gh actions ahead of set-output, node12 deprecation (#418)

* updating set-output (#450)

* updating set-output

* add back run, move comment

---------

Co-authored-by: David Bloss <[email protected]>
emmyoop added a commit that referenced this pull request Jun 5, 2023
@emmyoop @davidbloss
[Backport] 1.0.latest gh deprecations (#443)
3e00294 
* update used gh actions ahead of set-output, node12 deprecation (#418)

* updating set-output (#450)

* updating set-output

* add back run, move comment

---------

Co-authored-by: David Bloss <[email protected]>
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
@emmyoop
updating set-output (dbt-labs#450)
55ba5c8 
* updating set-output

* add back run, move comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 approved these changes

@davidbloss davidbloss davidbloss approved these changes

@mikealfare mikealfare mikealfare approved these changes

@aranke aranke Awaiting requested review from aranke aranke was automatically assigned from dbt-labs/guild-oss-tooling

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1681] Replace deprecated exception functions
4 participants
@emmyoop @mikealfare @davidbloss @McKnight-42