Skip to content

Commit

Permalink
[Backport] 1.3.latest gh deprecations (#445)
Browse files Browse the repository at this point in the history
* update used gh actions ahead of set-output, node12 deprecation (#418)

* updating set-output (#450)

* updating set-output

* add back run, move comment

---------

Co-authored-by: David Bloss <[email protected]>
  • Loading branch information
emmyoop and davidbloss authored May 16, 2023
1 parent d27b632 commit 02bca0c
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 18 deletions.
19 changes: 10 additions & 9 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,13 @@ jobs:
steps:
- name: Check out the repository (non-PR)
if: github.event_name != 'pull_request_target'
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
persist-credentials: false

- name: Check out the repository (PR)
if: github.event_name == 'pull_request_target'
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
persist-credentials: false
ref: ${{ github.event.pull_request.head.sha }}
Expand All @@ -96,7 +96,7 @@ jobs:
- name: Generate integration test matrix
id: generate-matrix
uses: actions/github-script@v4
uses: actions/github-script@v6
env:
CHANGES: ${{ steps.get-changes.outputs.changes }}
with:
Expand Down Expand Up @@ -135,15 +135,15 @@ jobs:
steps:
- name: Check out the repository
if: github.event_name != 'pull_request_target'
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
persist-credentials: false

# explicity checkout the branch for the PR,
# this is necessary for the `pull_request_target` event
- name: Check out the repository (PR)
if: github.event_name == 'pull_request_target'
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
persist-credentials: false
ref: ${{ github.event.pull_request.head.sha }}
Expand Down Expand Up @@ -173,7 +173,7 @@ jobs:
DBT_TEST_USER_3: dbt_test_user_3
run: tox

- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v3
if: always()
with:
name: logs
Expand All @@ -182,9 +182,10 @@ jobs:
- name: Get current date
if: always()
id: date
run: echo "::set-output name=date::$(date +'%Y-%m-%dT%H_%M_%S')" #no colons allowed for artifacts
run: |
echo "date=$(date +'%Y-%m-%dT%H_%M_%S')" >> $GITHUB_OUTPUT #no colons allowed for artifacts
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v3
if: always()
with:
name: integration_results_${{ matrix.python-version }}_${{ matrix.os }}_${{ matrix.adapter }}-${{ steps.date.outputs.date }}.csv
Expand Down Expand Up @@ -220,7 +221,7 @@ jobs:

steps:
- name: Posting scheduled run failures
uses: ravsamhq/notify-slack-action@v1
uses: ravsamhq/notify-slack-action@v2
if: ${{ github.event_name == 'schedule' }}
with:
notification_title: 'Redshift nightly integration test failed'
Expand Down
19 changes: 10 additions & 9 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:

steps:
- name: Check out the repository
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
persist-credentials: false

Expand Down Expand Up @@ -80,7 +80,7 @@ jobs:

steps:
- name: Check out the repository
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
persist-credentials: false

Expand All @@ -102,9 +102,11 @@ jobs:
- name: Get current date
if: always()
id: date
run: echo "::set-output name=date::$(date +'%Y-%m-%dT%H_%M_%S')" #no colons allowed for artifacts
#no colons allowed for artifacts
run: |
echo "date=$(date +'%Y-%m-%dT%H_%M_%S')" >> $GITHUB_OUTPUT
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v3
if: always()
with:
name: unit_results_${{ matrix.python-version }}-${{ steps.date.outputs.date }}.csv
Expand All @@ -120,7 +122,7 @@ jobs:

steps:
- name: Check out the repository
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
persist-credentials: false

Expand Down Expand Up @@ -154,9 +156,8 @@ jobs:
run: |
export is_alpha=0
if [[ "$(ls -lh dist/)" == *"a1"* ]]; then export is_alpha=1; fi
echo "::set-output name=is_alpha::$is_alpha"
- uses: actions/upload-artifact@v2
echo "is_alpha=$is_alpha" >> $GITHUB_OUTPUT
- uses: actions/upload-artifact@v3
with:
name: dist
path: dist/
Expand Down Expand Up @@ -188,7 +189,7 @@ jobs:
python -m pip install --upgrade wheel
python -m pip --version
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v3
with:
name: dist
path: dist/
Expand Down

0 comments on commit 02bca0c

Please sign in to comment.