Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin types-requests in dev-requirements #8788

Merged
merged 2 commits into from
Oct 6, 2023
Merged

pin types-requests in dev-requirements #8788

merged 2 commits into from
Oct 6, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Oct 6, 2023

resolves #8789

Problem

When installing dev dependencies you get the following error:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behavior is the source of the following dependency conflicts.
types-requests 2.31.0.8 requires urllib3>=2, but you have urllib3 1.26.17 which is incompatible.

We have urllib3 pinned to version 1 because requests depends on openssl (#7573)

Solution

Pin types-requests in dev-requirements.txt to get it working for now.

Look into if/when we can unpin urllib3. #8790

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop requested a review from a team as a code owner October 6, 2023 14:26
@emmyoop emmyoop requested a review from MichelleArk October 6, 2023 14:26
@cla-bot cla-bot bot added the cla:yes label Oct 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f302933) 86.54% compared to head (f06011e) 86.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8788      +/-   ##
==========================================
- Coverage   86.54%   86.50%   -0.05%     
==========================================
  Files         176      176              
  Lines       25843    25843              
==========================================
- Hits        22367    22355      -12     
- Misses       3476     3488      +12     
Flag Coverage Δ
integration 83.24% <ø> (-0.12%) ⬇️
unit 65.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop merged commit 17773bd into main Oct 6, 2023
50 checks passed
@emmyoop emmyoop deleted the er/pin-types-requests branch October 6, 2023 14:53
QMalcolm pushed a commit that referenced this pull request Oct 9, 2023
* pin types-requests

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3189] [Bug] make dev is broken due to dependency conflict
3 participants