Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2556] [Bug] urllib3 upgraded to 2.0, dropping support for OpenSSL < 1.1.1, breaking requests 2.29.0 #7573

Closed
2 tasks done
mikealfare opened this issue May 9, 2023 · 2 comments · Fixed by #7574
Closed
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@mikealfare
Copy link
Contributor

mikealfare commented May 9, 2023

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Running functional tests produces an error when trying to import requests:

ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with OpenSSL 1.0.2k-fips  26 Jan 2017. See: https://github.com/urllib3/urllib3/issues/2168

Expected Behavior

Functional tests run as expected.

Steps To Reproduce

  1. Rebuild your venv to pick up the latest versions of dependencies
  2. Run functional tests

Relevant log output

ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with OpenSSL 1.0.2k-fips  26 Jan 2017. See: https://github.com/urllib3/urllib3/issues/2168


### Environment

```markdown
- OS: any
- Python: any
- dbt: any that use urllib3 (likely via having no cap on urllib3)

Which database adapter are you using with dbt?

No response

Additional Context

Related issues:
urllib3/urllib3#2168
psf/requests#6432
https://github.com/urllib3/urllib3/releases/tag/2.0.0

Proposed Solution:
We need to pin urllib3 to 1.x

@mikealfare mikealfare added bug Something isn't working triage and removed triage labels May 9, 2023
@mikealfare mikealfare self-assigned this May 9, 2023
@github-actions github-actions bot changed the title [Bug] urllib3 upgraded to 2.0, dropping support for OpenSSL < 1.1.1, breaking requests 2.29.0 [CT-2556] [Bug] urllib3 upgraded to 2.0, dropping support for OpenSSL < 1.1.1, breaking requests 2.29.0 May 9, 2023
@garfieldthesam
Copy link

How I fixed this issue on MacOS Ventura 13:

python3 -m pip install --force-reinstall -v "urllib3~=1.0"

@adamroyjones
Copy link

@mikealfare: As OpenSSL 1.1.1 has now reached the end of its life (as of 2023-09-11), are there plans to unpin urllib3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants