Add config to disable metrics/exposures #5815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyoop
commented
Sep 12, 2022
emmyoop
commented
Sep 12, 2022
gshank
requested changes
Sep 12, 2022
emmyoop
force-pushed
the
er/ct-788-disable-metrics
branch
from
3019166 to
27ab056
Compare
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
emmyoop
requested review from
stu-k,
gshank and
callum-mcdata
and removed request for
a team
|
Just tested this on my local and can confirm that it works as expected with metrics. Adding the same metric to two different folders resulted in a compilation error. When adding the below code, the definition from one of the folder paths was disabled and thus didn't get picked up. metrics:
dbt_metrics_integration_tests:
testing_disabling__overridden:
+enabled: false
testing_disabling:
+enabled: true |
3 tasks
josephberni
pushed a commit
to Gousto/dbt-core
that referenced
this pull request
Sep 16, 2022
* first pass adding disabled functionality to metrics and exposures * first pass at getting metrics disabled * add unsaved file * fix up comments * Delete tmp.csv * fix test * add exposure logic, fix merge from main * change when nodes are added to manifest, finish tests * add changelog * removed unused code * minor cleanup
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5422
Description
Support disabling metrics and exposures via config.
Checklist
changie newto create a changelog entry