Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-788] Support disabling metrics + exposures #5422

Closed
jtcohen6 opened this issue Jun 29, 2022 · 1 comment · Fixed by #5815 or #5909
Closed

[CT-788] Support disabling metrics + exposures #5422

jtcohen6 opened this issue Jun 29, 2022 · 1 comment · Fixed by #5815 or #5909
Assignees
Labels
enhancement New feature or request exposures
Milestone

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jun 29, 2022

Pretty simple:

# models/specific_file.yml

metrics:
  - name: disabled_metric
    config:
      enabled: false
  
exposures:
  - name: disabled_exposure
    config:
      enabled: false
# dbt_project.yml

metrics:
  +enabled: false

exposures:
  +enabled: false

Expectations:

  • Moved to disabled section of manifest.json
  • Needs to work with partial parsing
  • If a disabled metric is referenced via metric(), it should raise an error at the end of parsing (just as ref() or source() do)

Grouping these together because I believe it would require touching the same code paths!

@github-actions github-actions bot changed the title Support disabling metrics + exposures [CT-788] Support disabling metrics + exposures Jun 29, 2022
@jtcohen6 jtcohen6 added this to the v1.3 milestone Jul 5, 2022
@emmyoop
Copy link
Member

emmyoop commented Jul 14, 2022

Need to make sure we loop over the right things anywhere we're looking at enabled nodes to ensure metrics/exposures are included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exposures
Projects
None yet
2 participants