Incremental model show reason for on_schema_change fail failures #5505
Conversation
When the incremental model fails, I do not get the context I need to easily fix my discrepency. Adding more info
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @ilanbenb |
|
Hello, |
Done :) |
Fix identation
Added changie changes
Trim whitespaces
jtcohen6
added
Team:Adapters
|
I will leave this to the adapter team to take a second pass and merge(assuming all tests passes, I don't see any reason they won't) |
| Extra info for easy anomaly detection: | ||
| Source columns not in target: {{ schema_changes_dict['source_not_in_target'] }} | ||
| Target columns not in source: {{ schema_changes_dict['target_not_in_source'] }} | ||
| New column types: {{ schema_changes_dict['new_target_types'] }} |
There was a problem hiding this comment.
@dbeatty10 @dataders Does either of you have thoughts on the specific language here?
There was a problem hiding this comment.
Something like "Additional troubleshooting context:" could be a drop-in replacement for "Extra info for easy anomaly detection:"
Side note: it's a bit unfortunate that "schema" is both the 2nd level in a three-level database.schema.relation hierarchy as well as the result of DDL operations on a relation.
There was a problem hiding this comment.
@dbeatty10 I updated the log message per your request. It looks better
Log message text enhancement
ilanbenb
changed the title
|
Hey, @VersusFacit @jtcohen6 This pr is stall for more than 15 days. Thanks, |
|
@ilanbenb sorry for the delay! I am merging this for the the Adapter team as all feedback has been addressed. Thanks for the contribution! |
* show reason for schema change failures When the incremental model fails, I do not get the context I need to easily fix my discrepency. Adding more info * Update on_schema_change.sql Fix identation * Added changie changes Added changie changes * Update on_schema_change.sql Trim whitespaces * Update on_schema_change.sql Log message text enhancement
…-labs#5505) * show reason for schema change failures When the incremental model fails, I do not get the context I need to easily fix my discrepency. Adding more info * Update on_schema_change.sql Fix identation * Added changie changes Added changie changes * Update on_schema_change.sql Trim whitespaces * Update on_schema_change.sql Log message text enhancement
resolves issue #5504
Description
When the incremental model fails, I do not get the context I need to easily fix my discrepancy.
Adding more verbosity.
Checklist
changie newto create a changelog entry