Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-875] [Bug] fail on_schema_changes error message not verbose enough #5504

Closed
1 task done
ilanbenb opened this issue Jul 20, 2022 · 2 comments
Closed
1 task done
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors! incremental Incremental modeling with dbt Team:Adapters Issues designated for the adapter area of the code

Comments

@ilanbenb
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Hello,
I am using DBT on posgresql.
When I use on_schema_changes on_schema_change='fail', I expect to get a verbose explanation of what the diff between the source and destination schemas are.

image

Expected Behavior

Getting extra information to fix my failed schema fast.

In this context:

{% set msg %} In {{ target_relation }}: Schema changed: {{ schema_changed }} Source columns not in target: {{ source_not_in_target }} Target columns not in source: {{ target_not_in_source }} New column types: {{ new_target_types }} {% endset %}

Steps To Reproduce

No response

Relevant log output

No response

Environment

- OS: mac and linux ( container based on  python:3.8-slim-buster  )
- Python: 3.8
- dbt: 1

What database are you using dbt with?

postgres

Additional Context

No response

@ilanbenb ilanbenb added bug Something isn't working triage labels Jul 20, 2022
@github-actions github-actions bot changed the title [Bug] fail on_schema_changes error message not verbose enough [CT-875] [Bug] fail on_schema_changes error message not verbose enough Jul 20, 2022
@jtcohen6 jtcohen6 added good_first_issue Straightforward + self-contained changes, good for new contributors! and removed triage labels Jul 21, 2022
@jtcohen6
Copy link
Contributor

@ilanbenb Great point, thanks for opening!

I think we include this info in a debug log message today, but making it available in the info-level logs will be all the easier for folks to discover.

I see you've already opened a PR for this, so I'm going to mark this a good_first_issue :)

@jtcohen6 jtcohen6 added incremental Incremental modeling with dbt Team:Adapters Issues designated for the adapter area of the code labels Jul 21, 2022
@ilanbenb
Copy link
Contributor Author

Pull request merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good_first_issue Straightforward + self-contained changes, good for new contributors! incremental Incremental modeling with dbt Team:Adapters Issues designated for the adapter area of the code
Projects
None yet
Development

No branches or pull requests

2 participants