Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-679] flip logic around reset color detection #5394

Merged
merged 4 commits into from
Jun 29, 2022
Merged

[CT-679] flip logic around reset color detection #5394

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
384d3a1
[CT-679] flip logic around reset color detection
darin-reify Jun 17, 2022
a520876
[CT-679] add changie file
darin-reify Jun 17, 2022
d46d59e
[CT-679] update all places that use the RESET_ALL
darin-reify Jun 22, 2022
4a6c0df
[CT-679] missed a blank line
darin-reify Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/unreleased/Fixes-20220617-160027.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
kind: Fixes
body: fixes handling of RESET color code with USE_COLORS=False
time: 2022-06-17T16:00:27.038058-04:00
custom:
Author: darin-reify
Issue: "5288"
PR: "5394"
2 changes: 1 addition & 1 deletion core/dbt/events/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ def create_debug_text_log_line(e: T_Event) -> str:
if type(e) == MainReportVersion:
separator = 30 * "="
log_line = f"\n\n{separator} {get_ts()} | {get_invocation_id()} {separator}\n"
color_tag: str = "" if this.format_color else Style.RESET_ALL
color_tag: str = "" if not this.format_color else Style.RESET_ALL
darin-reify marked this conversation as resolved.
Show resolved Hide resolved
ts: str = get_ts().strftime("%H:%M:%S.%f")
scrubbed_msg: str = scrub_secrets(e.message(), env_secrets())
level: str = e.level_tag() if len(e.level_tag()) == 5 else f"{e.level_tag()} "
Expand Down