-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-679] flip logic around reset color detection #5394
Conversation
- this makes is so that the reset color code won't be appended to logs when `use-colors` is false.
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @darin-reify |
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @darin-reify |
Darin: Can you sign one of the CLAs which is linked from https://docs.getdbt.com/docs/contributing/contributor-license-agreements? We can get this processed once that's done. Thanks! |
hey there, sorry was just crossing my t's and dotting my i's. i've signed the agreement! |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
- pull into a fn to avoid repetition
when
use-colors
is false.resolves #5288
Checklist
changie new
to create a changelog entry