[Backport] Fix microbatch dbt list --output JSON (#11187) #11203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, running this command on a project containing a microbatch model results in an error, as microbatch models require a datetime value in their config which cannot be serialized by the default JSON serializer. There already exists a custom JSON serializer within the dbt-core project that converts datetime to ISO string format. This change uses the above serializer to resolve the error.
MichelleArk
changed the title
QMalcolm
approved these changes
Jan 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.9.latest #11203 +/- ##
===========================================
Coverage 89.13% 89.13%
===========================================
Files 183 183
Lines 23895 23896 +1
===========================================
+ Hits 21298 21300 +2
+ Misses 2597 2596 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
graciegoheen
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #11187