Fix microbatch dbt list --output JSON #11187
Conversation
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @internetcoffeephone |
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
internetcoffeephone
force-pushed
the
fix-dbt-list-microbatch-json-serialization
branch
2 times, most recently
from
d260c24 to
704ceca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11187 +/- ##
==========================================
- Coverage 88.92% 86.22% -2.71%
==========================================
Files 187 187
Lines 24103 24104 +1
==========================================
- Hits 21434 20783 -651
- Misses 2669 3321 +652
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Currently, running this command on a project containing a microbatch model results in an error, as microbatch models require a datetime value in their config which cannot be serialized by the default JSON serializer. There already exists a custom JSON serializer within the dbt-core project that converts datetime to ISO string format. This change uses the above serializer to resolve the error.
internetcoffeephone
force-pushed
the
fix-dbt-list-microbatch-json-serialization
branch
from
704ceca to
f8b0760
Compare
Currently, running this command on a project containing a microbatch model results in an error, as microbatch models require a datetime value in their config which cannot be serialized by the default JSON serializer. There already exists a custom JSON serializer within the dbt-core project that converts datetime to ISO string format. This change uses the above serializer to resolve the error.
Resolves #10556, #11098
Problem
Currently, running
dbt list --output JSONon a project containing a microbatch model results in an error, as microbatch models require a datetime value in their config which cannot be serialized by the default JSON serializer.Solution
There already exists a custom JSON serializer within the dbt-core project that converts datetime to ISO string format. This change uses the above serializer to resolve the error.
Checklist