Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup #225 - fix logged job link #297

Closed
wants to merge 3 commits into from

Conversation

MartinNowak
Copy link

@MartinNowak MartinNowak commented Sep 6, 2022

fixup #250

Description

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@cla-bot
Copy link

cla-bot bot commented Sep 6, 2022

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @MartinNowak

@MartinNowak MartinNowak reopened this Sep 18, 2022
@cla-bot cla-bot bot added the cla:yes label Sep 18, 2022
@MartinNowak
Copy link
Author

Any chance we can get this reviewed and merged before 1.3.0 @McKnight-42 @jtcohen6

@Fleid
Copy link
Contributor

Fleid commented Jan 27, 2023

Hey @MartinNowak, sorry for the delay.
I can't find the reason that motivates the switch, have I missed a conversation somewhere? Thanks!

@VersusFacit
Copy link
Contributor

VersusFacit commented Jan 31, 2023

We'll need some context here to explain why we need to change the order of the if statement. Is this meant to be primarily syntactic? Because shifting the parameters could introduce boolean short-circuit related changes in logic (or perhaps the current order is bugged itself)

Also, is the order of these parameters wrong? Certainly share the context that led to these changes ✌️

@Fleid
Copy link
Contributor

Fleid commented Feb 15, 2023

I'll close for now, please re-open if need be!

@Fleid Fleid closed this Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants