-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add job_id/project_id to adapter response to enable easy job linking (fixed) #250
Conversation
if hasattr(error, "query_job"): | ||
logger.error( | ||
cls._bq_job_link( | ||
error.query_job.location, error.query_job.project, error.query_job.job_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previous PR had error.query_job.project_id
instead of error.query_job.project
which was a typo on my end
https://cloud.google.com/python/docs/reference/bigquery/latest/google.cloud.bigquery.job.QueryJob#google_cloud_bigquery_job_QueryJob_project
I ran locally:
So it looks like the failing test from previous PR is now passing 🤔 |
It looks like all tests are successful this time 🚀 |
@Kayrnt This is looking great ran the tests locally on my end as well and passing, the conflicts that are showing up are because we just added will ping some others to get double checks on this! |
I've updated the PR with changie approach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have tested locally, looking very good will merge in and keep eye on tests on main
Hooray! Thanks both for checking back into this, and getting it merge-ready 🚀 |
resolves #92
Description
Adding job_id / project_id from the job executed by BQ to add a clean link to explore the runtime in the BQ UI.
Practically, it adds a link in your
-d
runs such as:Fixed version following revert from #225
Checklist
CHANGELOG.md
and added information about my change to the "dbt-bigquery next" section.