This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Set up CI #3
Merged
Set up CI #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stephanh there's one more issue left until we can merge this (see comment above) 🙂 Do you think you could fix that? |
stephanh
force-pushed
the
ci
branch
2 times, most recently
from
5831e99 to
83f836b
Compare
|
@dbrgn it should be good to go now. |
dbrgn
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Perfect, thanks! I updated your commit messages to imperative style for consistency (https://365git.tumblr.com/post/3308646748/writing-git-commit-messages). Otherwise this is ready to merge.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For me to be able to raise contribute code I thought it might be best to first have a CI process.
I had to fix some minor fmt and clippy warnings to make the checks pass.