Merge pull request #3 from stephanh/ci

Set up CI

.github/workflows/ci.yml

@@ -0,0 +1,49 @@
+on: [push, pull_request]
+
+name: Continuous integration
+
+jobs:
+  test:
+    name: Test Suite
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          override: true
+      - name: Run tests
+        uses: actions-rs/cargo@v1
+        with:
+          command: test
+          args: --all-features
+
+  fmt:
+    name: Rustfmt
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          override: true
+      - run: rustup component add rustfmt
+      - uses: actions-rs/cargo@v1
+        with:
+          command: fmt
+          args: --all -- --check
+
+  clippy:
+    name: Clippy
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          override: true
+      - run: rustup component add clippy
+      - uses: actions-rs/cargo@v1
+        with:
+          command: clippy
+          args: -- -D warnings

Cargo.toml

@@ -19,7 +19,7 @@ numtoa = "0.2"
 [dev-dependencies]
 env_logger = "0.6"
 log = "0.4"
-serialport = { git = "https://gitlab.com/dbrgn/serialport-rs", branch = "embedded", features = ["embedded"] }
+serialport = { git = "https://gitlab.com/dbrgn/serialport-rs", branch = "embedded", features = ["embedded"], default_features = false }
 void = "1"
 
 [features]

src/commands/requests.rs

@@ -172,9 +172,10 @@ impl AtatCmd for SetWifiMode {
     type Response = responses::EmptyResponse;
 
     fn as_string(&self) -> String<Self::CommandLen> {
-        let mut string = String::from(match self.persist {
-            true => "AT+CWMODE_DEF=",
-            false => "AT+CWMODE_CUR=",
+        let mut string = String::from(if self.persist {
+            "AT+CWMODE_DEF="
+        } else {
+            "AT+CWMODE_CUR="
         });
         string.push_str(self.mode.as_at_str()).unwrap();
         string.push_str("\r\n").unwrap();
@@ -244,9 +245,10 @@ impl AtatCmd for JoinAccessPoint {
     type Response = responses::JoinResponse;
 
     fn as_string(&self) -> String<Self::CommandLen> {
-        let mut string = String::from(match self.persist {
-            true => "AT+CWJAP_DEF=",
-            false => "AT+CWJAP_CUR=",
+        let mut string = String::from(if self.persist {
+            "AT+CWJAP_DEF="
+        } else {
+            "AT+CWJAP_CUR="
         });
         // TODO: Proper quoting
         string.push('"').unwrap();
@@ -394,8 +396,8 @@ impl AtatCmd for EstablishConnection {
                 let octets = addr.ip().octets();
                 let mut buf = [0; 5];
                 string.push('"').unwrap();
-                for i in 0..=3 {
-                    string.push_str(octets[i].numtoa_str(10, &mut buf)).unwrap();
+                for (i, octet) in octets.iter().enumerate() {
+                    string.push_str(octet.numtoa_str(10, &mut buf)).unwrap();
                     if i != 3 {
                         string.push('.').unwrap();
                     }

src/types.rs

@@ -44,7 +44,6 @@ pub enum ConnectionStatus {
     Other(u8),
 }
 
-
 /// The ESP8266 can manage up to five parallel connections with id 0..4.
 #[derive(Debug)]
 pub enum ConnectionId {