Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: a bug fix to bigquery_to_datahub.yml file #3988

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Bug: a bug fix to bigquery_to_datahub.yml file #3988

merged 1 commit into from
Jan 27, 2022

Conversation

dipeshmaurya
Copy link
Contributor

@dipeshmaurya dipeshmaurya commented Jan 27, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@dipeshmaurya dipeshmaurya changed the title Update bigquery_to_datahub.yml Bug: a bug fix to bigquery_to_datahub.yml file Jan 27, 2022
shirshanka
shirshanka approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit ad0019c into datahub-project:master Jan 27, 2022
@github-actions
Copy link

Unit Test Results (build & test)

  45 files  ±0    45 suites  ±0   18m 9s ⏱️ + 5m 27s
505 tests ±0  449 ✔️ ±0  56 💤 ±0  0 ❌ ±0 

Results for commit dfe5c09. ± Comparison against base commit 9366a47.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   39m 29s ⏱️ + 2m 36s
   274 tests ±0     273 ✔️ ±0    0 💤 ±0  1 ❌ ±0 
1 261 runs  +2  1 232 ✔️ +8  28 💤  - 6  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit dfe5c09. ± Comparison against base commit 9366a47.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dipeshmaurya @shirshanka