Skip to content

Commit

Permalink
fix(quickstart): Assign correct mysql-setup container for M1 and remo…
Browse files Browse the repository at this point in the history
…ve "head" default version. (#3987)

Co-authored-by: Shirshanka Das <[email protected]>
  • Loading branch information
jjoyce0510 and shirshanka authored Jan 27, 2022
1 parent fe5a1f2 commit 9366a47
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docker-gms.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,6 @@ jobs:
with:
context: .
file: ./docker/datahub-gms/Dockerfile
platforms: linux/amd64,linux/arm64
platforms: linux/amd64
tags: ${{ steps.docker_meta.outputs.tags }}
push: ${{ needs.setup.outputs.publish == 'true' }}
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ services:
- MYSQL_PASSWORD=datahub
- DATAHUB_DB_NAME=datahub
hostname: mysql-setup
image: acryldata/datahub-mysql-setup:v0.8.23
image: acryldata/datahub-mysql-setup:v0.8.23.0
schema-registry:
container_name: schema-registry
depends_on:
Expand Down
7 changes: 4 additions & 3 deletions metadata-ingestion/src/datahub/cli/docker.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ def should_use_neo4j_for_graph_service(graph_service_override: Optional[str]) ->
@click.option(
"--version",
type=str,
default="head",
help="Datahub version to be deployed. If not set, deploy latest",
default=None,
help="Datahub version to be deployed. If not set, deploy using the defaults from the quickstart compose",
)
@click.option(
"--build-locally",
Expand Down Expand Up @@ -218,7 +218,8 @@ def quickstart(
logger.debug(f"Copied to {path}")

# set version
os.environ["DATAHUB_VERSION"] = version
if version is not None:
os.environ["DATAHUB_VERSION"] = version

base_command: List[str] = [
"docker-compose",
Expand Down

0 comments on commit 9366a47

Please sign in to comment.