Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/gc): logging and stopping fix #12266

Merged
merged 6 commits into from
Jan 3, 2025

add test for report update

99cd284
Select commit
Loading
Failed to load commit list.
Merged

fix(ingest/gc): logging and stopping fix #12266

add test for report update
99cd284
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 3, 2025 in 0s

21.05% of diff hit (target 75.07%)

View this Pull Request on Codecov

21.05% of diff hit (target 75.07%)

Annotations

Check warning on line 163 in metadata-ingestion/src/datahub/ingestion/source/gc/execution_request_cleanup.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/ingestion/source/gc/execution_request_cleanup.py#L163 

Added line #L163 was not covered by tests

Check warning on line 239 in metadata-ingestion/src/datahub/ingestion/source/gc/execution_request_cleanup.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/ingestion/source/gc/execution_request_cleanup.py#L239 

Added line #L239 was not covered by tests

Check warning on line 169 in metadata-ingestion/src/datahub/ingestion/source/gc/soft_deleted_entity_cleanup.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/ingestion/source/gc/soft_deleted_entity_cleanup.py#L168-L169 

Added lines #L168 - L169 were not covered by tests

Check warning on line 281 in metadata-ingestion/src/datahub/ingestion/source/gc/soft_deleted_entity_cleanup.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/ingestion/source/gc/soft_deleted_entity_cleanup.py#L281 

Added line #L281 was not covered by tests

Check warning on line 288 in metadata-ingestion/src/datahub/ingestion/source/gc/soft_deleted_entity_cleanup.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/ingestion/source/gc/soft_deleted_entity_cleanup.py#L285-L288 

Added lines #L285 - L288 were not covered by tests

Check warning on line 291 in metadata-ingestion/src/datahub/ingestion/source/gc/soft_deleted_entity_cleanup.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/ingestion/source/gc/soft_deleted_entity_cleanup.py#L291 

Added line #L291 was not covered by tests

Check warning on line 298 in metadata-ingestion/src/datahub/ingestion/source/gc/soft_deleted_entity_cleanup.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/ingestion/source/gc/soft_deleted_entity_cleanup.py#L295-L298 

Added lines #L295 - L298 were not covered by tests

Check warning on line 311 in metadata-ingestion/src/datahub/ingestion/source/gc/soft_deleted_entity_cleanup.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

metadata-ingestion/src/datahub/ingestion/source/gc/soft_deleted_entity_cleanup.py#L311 

Added line #L311 was not covered by tests
View more details on Codecov