Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/gc): logging and stopping fix #12266

Merged
merged 6 commits into from
Jan 3, 2025
Merged

fix(ingest/gc): logging and stopping fix #12266

merged 6 commits into from
Jan 3, 2025

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Jan 3, 2025 •
edited
Loading

  • Use structured reporting for failures
  • Use time limit and deletion limit in underlying method so we stop in all threads from deletion

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Jan 3, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Jan 3, 2025
sgomezvillamor
sgomezvillamor approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@sgomezvillamor sgomezvillamor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just some suggestions on consistent capitalization and style

metadata-ingestion/src/datahub/ingestion/source/gc/execution_request_cleanup.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/gc/execution_request_cleanup.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/gc/soft_deleted_entity_cleanup.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/gc/soft_deleted_entity_cleanup.py Outdated Show resolved Hide resolved
metadata-ingestion/src/datahub/ingestion/source/gc/soft_deleted_entity_cleanup.py Outdated Show resolved Hide resolved
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Jan 3, 2025
@anshbansal anshbansal merged commit f9e2c49 into master Jan 3, 2025
79 of 80 checks passed
@anshbansal anshbansal deleted the ab-fix-ingest-limit branch January 3, 2025 16:45
brock-acryl pushed a commit to brock-acryl/datahub that referenced this pull request Jan 30, 2025
@anshbansal @chakru-r
fix(ingest/gc): logging and stopping fix (datahub-project#12266)
a902a3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgomezvillamor sgomezvillamor sgomezvillamor approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @sgomezvillamor