Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpile documentation for installation and usage #73

Merged
merged 8 commits into from
Jan 19, 2024

Conversation

ganeshdogiparthi-db
Copy link
Contributor

Environment Setup
Installation
Usage
related screenshots and gif

@ganeshdogiparthi-db ganeshdogiparthi-db added the documentation Improvements or additions to documentation label Jan 12, 2024
@ganeshdogiparthi-db ganeshdogiparthi-db requested a review from a team as a code owner January 12, 2024 06:55
@sundarshankar89 sundarshankar89 requested review from sundarshankar89 and nfx and removed request for himanishk January 12, 2024 07:39
Copy link
Collaborator

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't use colors
  2. try to use https://mermaid.live/ to version-control diagrams in markdown

README.md Outdated
1. [Introduction](#introduction)
- [Transpile](#transpile)
2. [Environment Setup](#environmentsetup)
3. [How to use Transpile](#howtouse)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not transpile, but remorph

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Added separate descriptions for Remorph and Transpile. In the future when Reconcile is added. We can add that time.

README.md Outdated
Transpile stands out as a comprehensive and versatile SQL transpiler, boasting a robust test suite to ensure reliability. Developed entirely in Python, it not only demonstrates high performance but also highlights syntax errors and provides warnings or raises alerts for dialect incompatibilities based on configurations.

#### Design Flow:
![transplie_flow](docs/transplie-flow.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace docs/transplie-flow.png with mermaid diagrams, so that they're version control - https://github.blog/2022-02-14-include-diagrams-markdown-files-mermaid/. e.g. this is how easy it is

flowchart LR
  A --> B
  B --> C
  C --> D
  A --> D
Loading

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Removed the png file and added mermaid markdown

README.md Outdated
Comment on lines 14 to 15
# <span style="color: #FF5733;" id="introduction"> Introduction </span>
## <span style="color: #007ACC;" id="transpile"> Transpile </span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# <span style="color: #FF5733;" id="introduction"> Introduction </span>
## <span style="color: #007ACC;" id="transpile"> Transpile </span>

don't use HTML tags

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.md Outdated

----

# <span style="color: #FF5733;" id="environmentsetup"> Environment Setup </span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use normal headers, no colors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.md Outdated

# <span style="color: #FF5733;" id="environmentsetup"> Environment Setup </span>

1. **<span style="color: #007ACC;">Databricks Cli - </span>** Ensure that you have the Databricks Command-Line Interface (CLI) installed on your machine. Refer to the installation instructions provided for Linux, MacOS, and Windows, available [here](https://docs.databricks.com/en/dev-tools/cli/install.html#install-or-update-the-databricks-cli).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no colors, use markdown.

Suggested change
1. **<span style="color: #007ACC;">Databricks Cli - </span>** Ensure that you have the Databricks Command-Line Interface (CLI) installed on your machine. Refer to the installation instructions provided for Linux, MacOS, and Windows, available [here](https://docs.databricks.com/en/dev-tools/cli/install.html#install-or-update-the-databricks-cli).
1. `Databricks CLI` Ensure that you have the Databricks Command-Line Interface (CLI) installed on your machine. Refer to the installation instructions provided for Linux, MacOS, and Windows, available [here](https://docs.databricks.com/en/dev-tools/cli/install.html#install-or-update-the-databricks-cli).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@nfx nfx merged commit 7fbe86a into main Jan 19, 2024
3 checks passed
@ganeshdogiparthi-db ganeshdogiparthi-db deleted the feature/transpile_documentation branch January 22, 2024 02:48
nfx added a commit that referenced this pull request Jan 30, 2024
* Added custom Databricks dialect test cases and lateral struct parsing ([#77](#77)).
* Extended Snowflake to Databricks functions coverage ([#72](#72), [#69](#69)).
* Added `databricks labs remorph transpile` documentation for installation and usage ([#73](#73)).

Dependency updates:

 * Bump sqlglot from 20.8.0 to 20.9.0 ([#83](#83)).
 * Updated databricks-sdk requirement from ~=0.17.0 to ~=0.18.0 ([#90](#90)).
 * Bump sqlglot from 20.9.0 to 20.10.0 ([#91](#91)).
nfx added a commit that referenced this pull request Jan 30, 2024
* Added baseline for Databricks CLI frontend ([#60](#60)).
* Added custom Databricks dialect test cases and lateral struct parsing ([#77](#77)).
* Extended Snowflake to Databricks functions coverage ([#72](#72), [#69](#69)).
* Added `databricks labs remorph transpile` documentation for installation and usage ([#73](#73)).

Dependency updates:

 * Bump sqlglot from 20.8.0 to 20.9.0 ([#83](#83)).
 * Updated databricks-sdk requirement from ~=0.17.0 to ~=0.18.0 ([#90](#90)).
 * Bump sqlglot from 20.9.0 to 20.10.0 ([#91](#91)).
@nfx nfx mentioned this pull request Jan 30, 2024
nfx added a commit that referenced this pull request Jan 30, 2024
* Added baseline for Databricks CLI frontend ([#60](#60)).
* Added custom Databricks dialect test cases and lateral struct parsing ([#77](#77)).
* Extended Snowflake to Databricks functions coverage ([#72](#72), [#69](#69)).
* Added `databricks labs remorph transpile` documentation for installation and usage ([#73](#73)).

Dependency updates:

 * Bump sqlglot from 20.8.0 to 20.9.0 ([#83](#83)).
 * Updated databricks-sdk requirement from ~=0.17.0 to ~=0.18.0 ([#90](#90)).
 * Bump sqlglot from 20.9.0 to 20.10.0 ([#91](#91)).
@nfx nfx mentioned this pull request Jan 30, 2024
sundarshankar89 pushed a commit that referenced this pull request Jan 30, 2024
* Added baseline for Databricks CLI frontend
([#60](#60)).
* Added custom Databricks dialect test cases and lateral struct parsing
([#77](#77)).
* Extended Snowflake to Databricks functions coverage
([#72](#72),
[#69](#69)).
* Added `databricks labs remorph transpile` documentation for
installation and usage
([#73](#73)).

Dependency updates:

* Bump sqlglot from 20.8.0 to 20.9.0
([#83](#83)).
* Updated databricks-sdk requirement from ~=0.17.0 to ~=0.18.0
([#90](#90)).
* Bump sqlglot from 20.9.0 to 20.10.0
([#91](#91)).
sundarshankar89 pushed a commit to sundarshankar89/remorph that referenced this pull request Jan 2, 2025
sundarshankar89 pushed a commit to sundarshankar89/remorph that referenced this pull request Jan 3, 2025
sundarshankar89 pushed a commit to sundarshankar89/remorph that referenced this pull request Jan 3, 2025
* Added baseline for Databricks CLI frontend
([databrickslabs#60](databrickslabs#60)).
* Added custom Databricks dialect test cases and lateral struct parsing
([databrickslabs#77](databrickslabs#77)).
* Extended Snowflake to Databricks functions coverage
([databrickslabs#72](databrickslabs#72),
[databrickslabs#69](databrickslabs#69)).
* Added `databricks labs remorph transpile` documentation for
installation and usage
([databrickslabs#73](databrickslabs#73)).

Dependency updates:

* Bump sqlglot from 20.8.0 to 20.9.0
([databrickslabs#83](databrickslabs#83)).
* Updated databricks-sdk requirement from ~=0.17.0 to ~=0.18.0
([databrickslabs#90](databrickslabs#90)).
* Bump sqlglot from 20.9.0 to 20.10.0
([databrickslabs#91](databrickslabs#91)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants