Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Snowflake to Databricks functions coverage 2 #72

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Extend Snowflake to Databricks functions coverage 2 #72

merged 1 commit into from
Jan 12, 2024

Conversation

vijaypavann-db
Copy link
Contributor

Added the below functions:

  • MONTH_NAME
  • OBJECT_CONSTRUCT
  • OBJECT_KEYS
  • TRY_PARSE_JSON
  • DATEADD
  • DATEDIFF
  • TIMEDIFF
  • TIMESTAMPDIFF
  • TO_BOOLEAN
  • TO_DECIMAL
  • TO_DOUBLE
  • TO_NUMBER
  • TO_NUMERIC
  • TO_OBJECT
  • TO_TIME
  • TIMESTAMP_FROM_PARTS
  • TO_VARIANT
  • TO_BASE64
  • FROM_BASE64
  • TRY_BASE64_DECODE_STRING
  • TRY_TO_BOOLEAN
  • UUID_STRING

@vijaypavann-db vijaypavann-db requested a review from a team as a code owner January 12, 2024 06:36
sundarshankar89
sundarshankar89 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (same as earlier reviewed #68, with cleaner git commit history)

@sundarshankar89 sundarshankar89 added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit b002149 Jan 12, 2024
3 checks passed
@sundarshankar89 sundarshankar89 deleted the feature/sf-db-functions-coverage-2 branch January 12, 2024 06:43
bishwajit-db pushed a commit that referenced this pull request Jan 12, 2024
@vijaypavann-db @bishwajit-db
Extend Snowflake to Databricks functions coverage 2 (#72)
59162f3 
Added the below functions: 

- MONTH_NAME
- OBJECT_CONSTRUCT
- OBJECT_KEYS
- TRY_PARSE_JSON
- DATEADD
- DATEDIFF
- TIMEDIFF
- TIMESTAMPDIFF
- TO_BOOLEAN
- TO_DECIMAL
- TO_DOUBLE
- TO_NUMBER
- TO_NUMERIC
- TO_OBJECT
- TO_TIME
- TIMESTAMP_FROM_PARTS
- TO_VARIANT
- TO_BASE64
- FROM_BASE64
- TRY_BASE64_DECODE_STRING
- TRY_TO_BOOLEAN
- UUID_STRING
nfx pushed a commit that referenced this pull request Jan 24, 2024
@vijaypavann-db @nfx
Extend Snowflake to Databricks functions coverage 2 (#72)
b4c619d 
Added the below functions: 

- MONTH_NAME
- OBJECT_CONSTRUCT
- OBJECT_KEYS
- TRY_PARSE_JSON
- DATEADD
- DATEDIFF
- TIMEDIFF
- TIMESTAMPDIFF
- TO_BOOLEAN
- TO_DECIMAL
- TO_DOUBLE
- TO_NUMBER
- TO_NUMERIC
- TO_OBJECT
- TO_TIME
- TIMESTAMP_FROM_PARTS
- TO_VARIANT
- TO_BASE64
- FROM_BASE64
- TRY_BASE64_DECODE_STRING
- TRY_TO_BOOLEAN
- UUID_STRING
nfx added a commit that referenced this pull request Jan 30, 2024
@nfx
* Added baseline for Databricks CLI frontend ([#60](#60)).
e4f914c 
* Added custom Databricks dialect test cases and lateral struct parsing ([#77](#77)).
* Extended Snowflake to Databricks functions coverage ([#72](#72), [#69](#69)).
* Added `databricks labs remorph transpile` documentation for installation and usage ([#73](#73)).

Dependency updates:

 * Bump sqlglot from 20.8.0 to 20.9.0 ([#83](#83)).
 * Updated databricks-sdk requirement from ~=0.17.0 to ~=0.18.0 ([#90](#90)).
 * Bump sqlglot from 20.9.0 to 20.10.0 ([#91](#91)).
@nfx nfx mentioned this pull request Jan 30, 2024
Closed
nfx added a commit that referenced this pull request Jan 30, 2024
@nfx
## 0.1.0
9d41ff1 
* Added baseline for Databricks CLI frontend ([#60](#60)).
* Added custom Databricks dialect test cases and lateral struct parsing ([#77](#77)).
* Extended Snowflake to Databricks functions coverage ([#72](#72), [#69](#69)).
* Added `databricks labs remorph transpile` documentation for installation and usage ([#73](#73)).

Dependency updates:

 * Bump sqlglot from 20.8.0 to 20.9.0 ([#83](#83)).
 * Updated databricks-sdk requirement from ~=0.17.0 to ~=0.18.0 ([#90](#90)).
 * Bump sqlglot from 20.9.0 to 20.10.0 ([#91](#91)).
@nfx nfx mentioned this pull request Jan 30, 2024
Closed
nfx added a commit that referenced this pull request Jan 30, 2024
@nfx
Release v0.1.0
af6d1a8 
* Added baseline for Databricks CLI frontend ([#60](#60)).
* Added custom Databricks dialect test cases and lateral struct parsing ([#77](#77)).
* Extended Snowflake to Databricks functions coverage ([#72](#72), [#69](#69)).
* Added `databricks labs remorph transpile` documentation for installation and usage ([#73](#73)).

Dependency updates:

 * Bump sqlglot from 20.8.0 to 20.9.0 ([#83](#83)).
 * Updated databricks-sdk requirement from ~=0.17.0 to ~=0.18.0 ([#90](#90)).
 * Bump sqlglot from 20.9.0 to 20.10.0 ([#91](#91)).
@nfx nfx mentioned this pull request Jan 30, 2024
Merged
sundarshankar89 pushed a commit that referenced this pull request Jan 30, 2024
@nfx
Release v0.1.0 (#102)
7d4e708 
* Added baseline for Databricks CLI frontend
([#60](#60)).
* Added custom Databricks dialect test cases and lateral struct parsing
([#77](#77)).
* Extended Snowflake to Databricks functions coverage
([#72](#72),
[#69](#69)).
* Added `databricks labs remorph transpile` documentation for
installation and usage
([#73](#73)).

Dependency updates:

* Bump sqlglot from 20.8.0 to 20.9.0
([#83](#83)).
* Updated databricks-sdk requirement from ~=0.17.0 to ~=0.18.0
([#90](#90)).
* Bump sqlglot from 20.9.0 to 20.10.0
([#91](#91)).
sundarshankar89 pushed a commit to sundarshankar89/remorph that referenced this pull request Jan 2, 2025
@vijaypavann-db @nfx
Extend Snowflake to Databricks functions coverage 2 (databrickslabs#72)
0451647 
Added the below functions: 

- MONTH_NAME
- OBJECT_CONSTRUCT
- OBJECT_KEYS
- TRY_PARSE_JSON
- DATEADD
- DATEDIFF
- TIMEDIFF
- TIMESTAMPDIFF
- TO_BOOLEAN
- TO_DECIMAL
- TO_DOUBLE
- TO_NUMBER
- TO_NUMERIC
- TO_OBJECT
- TO_TIME
- TIMESTAMP_FROM_PARTS
- TO_VARIANT
- TO_BASE64
- FROM_BASE64
- TRY_BASE64_DECODE_STRING
- TRY_TO_BOOLEAN
- UUID_STRING
sundarshankar89 pushed a commit to sundarshankar89/remorph that referenced this pull request Jan 3, 2025
@vijaypavann-db @nfx
Extend Snowflake to Databricks functions coverage 2 (databrickslabs#72)
cb6afbe 
Added the below functions: 

- MONTH_NAME
- OBJECT_CONSTRUCT
- OBJECT_KEYS
- TRY_PARSE_JSON
- DATEADD
- DATEDIFF
- TIMEDIFF
- TIMESTAMPDIFF
- TO_BOOLEAN
- TO_DECIMAL
- TO_DOUBLE
- TO_NUMBER
- TO_NUMERIC
- TO_OBJECT
- TO_TIME
- TIMESTAMP_FROM_PARTS
- TO_VARIANT
- TO_BASE64
- FROM_BASE64
- TRY_BASE64_DECODE_STRING
- TRY_TO_BOOLEAN
- UUID_STRING
sundarshankar89 pushed a commit to sundarshankar89/remorph that referenced this pull request Jan 3, 2025
@nfx
Release v0.1.0 (databrickslabs#102)
42398d3 
* Added baseline for Databricks CLI frontend
([databrickslabs#60](databrickslabs#60)).
* Added custom Databricks dialect test cases and lateral struct parsing
([databrickslabs#77](databrickslabs#77)).
* Extended Snowflake to Databricks functions coverage
([databrickslabs#72](databrickslabs#72),
[databrickslabs#69](databrickslabs#69)).
* Added `databricks labs remorph transpile` documentation for
installation and usage
([databrickslabs#73](databrickslabs#73)).

Dependency updates:

* Bump sqlglot from 20.8.0 to 20.9.0
([databrickslabs#83](databrickslabs#83)).
* Updated databricks-sdk requirement from ~=0.17.0 to ~=0.18.0
([databrickslabs#90](databrickslabs#90)).
* Bump sqlglot from 20.9.0 to 20.10.0
([databrickslabs#91](databrickslabs#91)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundarshankar89 sundarshankar89 sundarshankar89 approved these changes

@bishwajit-db bishwajit-db Awaiting requested review from bishwajit-db bishwajit-db was automatically assigned from databrickslabs/remorph-write

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vijaypavann-db @sundarshankar89