-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notebook for transpilation added #1421
base: main
Are you sure you want to change the base?
Changes from 2 commits
cb5ec24
72cee82
42ee77e
201ca41
060ee3e
2f62840
44feb4c
bf2dd9c
e18dd26
f15beb4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would suggest to put this file under src/databricks/labs/remorph/resources/transpile and copy this to remorph install directory during remorph installation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This notebook should source notebook not stored as .dbc and should be installed inside installation directory. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the README, we can suggest the user to refer to the notebook example given in the resource dir (see comment below for .dbc file) and use it if they don't want to use the usual installation process but still want to use a notebook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done