notebook for transpilation added #1421
Conversation
There was a problem hiding this comment.
I would suggest to put this file under src/databricks/labs/remorph/resources/transpile and copy this to remorph install directory during remorph installation.
There was a problem hiding this comment.
This notebook should source notebook not stored as .dbc and should be installed inside installation directory.
README.md
Outdated
|
|
||
| ## NOTEBOOK LINK(TRANSPILATION only) | ||
|  | ||
| We would like to inform you that we have introduced a notebook-based installation process. However, please note that this notebook is exclusively designed for the purpose of transpilation. |
There was a problem hiding this comment.
In the README, we can suggest the user to refer to the notebook example given in the resource dir (see comment below for .dbc file) and use it if they don't want to use the usual installation process but still want to use a notebook.
There was a problem hiding this comment.
This notebook should source notebook not stored as .dbc and should be installed inside installation directory.
|
|
||
| # Initialize the WorkspaceClient with the specified product and version and TranspileConfig object with the provided configuration parameters. | ||
| wsclient = WorkspaceClient(product="remorph", product_version="0.9.0") | ||
| mrophconfig = MorphConfig( |
There was a problem hiding this comment.
typo in mrophconfig should be morph_config
| # Initialize the WorkspaceClient with the specified product and version and TranspileConfig object with the provided configuration parameters. | ||
| wsclient = WorkspaceClient(product="remorph", product_version="0.9.0") | ||
| mrophconfig = MorphConfig( | ||
| source=source_dialect, |
There was a problem hiding this comment.
should be source_dialect
| wsclient = WorkspaceClient(product="remorph", product_version="0.9.0") | ||
| mrophconfig = MorphConfig( | ||
| source=source_dialect, | ||
| input_sql=input_source, |
There was a problem hiding this comment.
should be input_source
Yes @ericvergnaud i agree that it will break for next release. But some customers are asking for it for the currect release so making this version of notebook for current release. |
@sriram251-code Then shouldn't it be distributed manually to them, since this PR is not compatible with the current code ? |
|
|
||
| # Import necessary classes from the databricks SDK and remorph library | ||
| from databricks.sdk import WorkspaceClient | ||
| from databricks.labs.remorph.config import MorphConfig |
|
|
||
| # Initialize the WorkspaceClient with the specified product and version and TranspileConfig object with the provided configuration parameters. | ||
| wsclient = WorkspaceClient(product="remorph", product_version="0.9.0") | ||
| mrophconfig = MorphConfig( |
There was a problem hiding this comment.
should be TranspileConfig
| ) | ||
|
|
||
|
|
||
| status = execute.morph(workspace_client=wsclient, config=mrophconfig) |
There was a problem hiding this comment.
should be execute.transpile, and is missing a TranspileEngine argument
@ericvergnaud This code is very specific to 090 version. This notebook can be used for all the clients who want to use remorph now.We will be making the changes for the next released version. |
Added a new notebook which can be use to perform transpilation using Remorph.The notebook includes instructions and code for installing the Remorph library, setting up necessary configuration parameters, and executing the transpilation process.Updated the README.md with the above details.