Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WITHIN GROUP for ARRAY_AGG and LISTAGG functions #133

Merged
merged 5 commits into from
Feb 14, 2024

Conversation

bishwajit-db
Copy link
Contributor

Add support for WITHIN GROUP for ARRAY_AGG and LISTAGG functions. Fixes issue #121

@bishwajit-db bishwajit-db self-assigned this Feb 12, 2024
@bishwajit-db bishwajit-db requested a review from a team as a code owner February 12, 2024 08:56
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b4f986d) 92.26% compared to head (fbd79f5) 92.30%.

Files Patch % Lines
src/databricks/labs/remorph/snow/databricks.py 94.28% 1 Missing and 1 partial ⚠️
src/databricks/labs/remorph/snow/snowflake.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   92.26%   92.30%   +0.04%     
==========================================
  Files          14       14              
  Lines         892      936      +44     
  Branches      156      165       +9     
==========================================
+ Hits          823      864      +41     
- Misses         44       45       +1     
- Partials       25       27       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sundarshankar89
Copy link
Collaborator

@nsenno-dbr FYA.

@nsenno-dbr
Copy link
Contributor

LGTM

@sundarshankar89 sundarshankar89 added this pull request to the merge queue Feb 14, 2024
Merged via the queue into main with commit 350fb99 Feb 14, 2024
6 checks passed
@sundarshankar89 sundarshankar89 deleted the feature/arr_agg_list_agg_within_group_support branch February 14, 2024 04:24
sundarshankar89 added a commit that referenced this pull request Feb 15, 2024
* Added support for WITHIN GROUP for ARRAY_AGG and LISTAGG functions ([#133](#133)).
* Fixed Merge "INTO" for delete from syntax ([#129](#129)).
* Fixed `DATE TRUNC` parse errors ([#131](#131)).
* Patched Logger function call during wheel file ([#135](#135)).
* Patched extra call to root path ([#126](#126)).

Dependency updates:

 * Updated databricks-sdk requirement from ~=0.18.0 to >=0.18,<0.20 ([#134](#134)).
@sundarshankar89 sundarshankar89 mentioned this pull request Feb 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 15, 2024
* Added support for WITHIN GROUP for ARRAY_AGG and LISTAGG functions
([#133](#133)).
* Fixed Merge "INTO" for delete from syntax
([#129](#129)).
* Fixed `DATE TRUNC` parse errors
([#131](#131)).
* Patched Logger function call during wheel file
([#135](#135)).
* Patched extra call to root path
([#126](#126)).

Dependency updates:

* Updated databricks-sdk requirement from ~=0.18.0 to >=0.18,<0.20
([#134](#134)).
sundarshankar89 pushed a commit to sundarshankar89/remorph that referenced this pull request Jan 2, 2025
…abrickslabs#133)

Add support for WITHIN GROUP for ARRAY_AGG and LISTAGG functions. Fixes
issue databrickslabs#121
sundarshankar89 pushed a commit to sundarshankar89/remorph that referenced this pull request Jan 3, 2025
…abrickslabs#133)

Add support for WITHIN GROUP for ARRAY_AGG and LISTAGG functions. Fixes
issue databrickslabs#121
sundarshankar89 added a commit to sundarshankar89/remorph that referenced this pull request Jan 3, 2025
* Added support for WITHIN GROUP for ARRAY_AGG and LISTAGG functions
([databrickslabs#133](databrickslabs#133)).
* Fixed Merge "INTO" for delete from syntax
([databrickslabs#129](databrickslabs#129)).
* Fixed `DATE TRUNC` parse errors
([databrickslabs#131](databrickslabs#131)).
* Patched Logger function call during wheel file
([databrickslabs#135](databrickslabs#135)).
* Patched extra call to root path
([databrickslabs#126](databrickslabs#126)).

Dependency updates:

* Updated databricks-sdk requirement from ~=0.18.0 to >=0.18,<0.20
([databrickslabs#134](databrickslabs#134)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants