-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for WITHIN GROUP for ARRAY_AGG and LISTAGG functions #133
Merged
sundarshankar89
merged 5 commits into
main
from
feature/arr_agg_list_agg_within_group_support
Feb 14, 2024
Merged
Add support for WITHIN GROUP for ARRAY_AGG and LISTAGG functions #133
sundarshankar89
merged 5 commits into
main
from
feature/arr_agg_list_agg_within_group_support
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 92.26% 92.30% +0.04%
==========================================
Files 14 14
Lines 892 936 +44
Branches 156 165 +9
==========================================
+ Hits 823 864 +41
- Misses 44 45 +1
- Partials 25 27 +2 ☔ View full report in Codecov by Sentry. |
@nsenno-dbr FYA. |
nsenno-dbr
reviewed
Feb 12, 2024
LGTM |
nsenno-dbr
approved these changes
Feb 13, 2024
sundarshankar89
added a commit
that referenced
this pull request
Feb 15, 2024
* Added support for WITHIN GROUP for ARRAY_AGG and LISTAGG functions ([#133](#133)). * Fixed Merge "INTO" for delete from syntax ([#129](#129)). * Fixed `DATE TRUNC` parse errors ([#131](#131)). * Patched Logger function call during wheel file ([#135](#135)). * Patched extra call to root path ([#126](#126)). Dependency updates: * Updated databricks-sdk requirement from ~=0.18.0 to >=0.18,<0.20 ([#134](#134)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Added support for WITHIN GROUP for ARRAY_AGG and LISTAGG functions ([#133](#133)). * Fixed Merge "INTO" for delete from syntax ([#129](#129)). * Fixed `DATE TRUNC` parse errors ([#131](#131)). * Patched Logger function call during wheel file ([#135](#135)). * Patched extra call to root path ([#126](#126)). Dependency updates: * Updated databricks-sdk requirement from ~=0.18.0 to >=0.18,<0.20 ([#134](#134)).
sundarshankar89
pushed a commit
to sundarshankar89/remorph
that referenced
this pull request
Jan 2, 2025
…abrickslabs#133) Add support for WITHIN GROUP for ARRAY_AGG and LISTAGG functions. Fixes issue databrickslabs#121
sundarshankar89
pushed a commit
to sundarshankar89/remorph
that referenced
this pull request
Jan 3, 2025
…abrickslabs#133) Add support for WITHIN GROUP for ARRAY_AGG and LISTAGG functions. Fixes issue databrickslabs#121
sundarshankar89
added a commit
to sundarshankar89/remorph
that referenced
this pull request
Jan 3, 2025
* Added support for WITHIN GROUP for ARRAY_AGG and LISTAGG functions ([databrickslabs#133](databrickslabs#133)). * Fixed Merge "INTO" for delete from syntax ([databrickslabs#129](databrickslabs#129)). * Fixed `DATE TRUNC` parse errors ([databrickslabs#131](databrickslabs#131)). * Patched Logger function call during wheel file ([databrickslabs#135](databrickslabs#135)). * Patched extra call to root path ([databrickslabs#126](databrickslabs#126)). Dependency updates: * Updated databricks-sdk requirement from ~=0.18.0 to >=0.18,<0.20 ([databrickslabs#134](databrickslabs#134)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for WITHIN GROUP for ARRAY_AGG and LISTAGG functions. Fixes issue #121