Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect script for no-pylint-disable #1329

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

ericvergnaud
Copy link
Contributor

Our current script returns false positives for stacked PRs.
Upgrading it to the latest one from ucx

@ericvergnaud ericvergnaud requested a review from a team as a code owner December 9, 2024 13:28
Copy link

github-actions bot commented Dec 9, 2024

Coverage tests results

493 tests  ±0   455 ✅ ±0   5s ⏱️ -1s
  7 suites ±0    38 💤 ±0 
  7 files   ±0     0 ❌ ±0 

Results for commit 5e6f8ee. ± Comparison against base commit 669312a.

♻️ This comment has been updated with latest results.

@ericvergnaud
Copy link
Contributor Author

The no-lint-disabled failure comes from the added script

@ericvergnaud ericvergnaud self-assigned this Dec 9, 2024
@gueniai gueniai merged commit ccbb359 into main Dec 9, 2024
7 of 8 checks passed
@gueniai gueniai deleted the ci/fix-incorrect-no-cheat branch December 9, 2024 14:45
ericvergnaud added a commit that referenced this pull request Dec 9, 2024
…ature/multiplexer/isolate-sqlglot-dependencies

* feature/multiplexer/refactor-transpiler-config:
  fix docs
  Fix incorrect script for no-pylint-disable (#1329)
  Refactor python transpiler code (#1314)
  Properly translate Snowflake REGEXP_SUBSTR (#1312)
  Prevent Dependabot from upgrading Databricks Connect. (#1322)
  Bump org.apache.maven.plugins:maven-jar-plugin from 2.4 to 3.4.2 (#1318)
  Bump com.lihaoyi:ujson_2.12 from 3.0.0-M2 to 4.0.2 (#1311)
  Bump org.scoverage:scoverage-maven-plugin from 2.0.5 to 2.0.6 (#1308)
  Bump com.databricks:databricks-sdk-java from 0.21.0 to 0.36.0 (#1292)
ericvergnaud added a commit that referenced this pull request Dec 9, 2024
…feature/multiplexer/rename-fixture

* feature/multiplexer/isolate-sqlglot-dependencies:
  fix docs
  Fix incorrect script for no-pylint-disable (#1329)
  Refactor python transpiler code (#1314)
  Properly translate Snowflake REGEXP_SUBSTR (#1312)
  Prevent Dependabot from upgrading Databricks Connect. (#1322)
  Bump org.apache.maven.plugins:maven-jar-plugin from 2.4 to 3.4.2 (#1318)
  Bump com.lihaoyi:ujson_2.12 from 3.0.0-M2 to 4.0.2 (#1311)
  Bump org.scoverage:scoverage-maven-plugin from 2.0.5 to 2.0.6 (#1308)
  Bump com.databricks:databricks-sdk-java from 0.21.0 to 0.36.0 (#1292)
ericvergnaud added a commit that referenced this pull request Dec 9, 2024
…lexer/create-launcher-from-cli

* feature/multiplexer/rename-fixture:
  fix docs
  Fix incorrect script for no-pylint-disable (#1329)
  Refactor python transpiler code (#1314)
  Properly translate Snowflake REGEXP_SUBSTR (#1312)
  Prevent Dependabot from upgrading Databricks Connect. (#1322)
  Bump org.apache.maven.plugins:maven-jar-plugin from 2.4 to 3.4.2 (#1318)
  Bump com.lihaoyi:ujson_2.12 from 3.0.0-M2 to 4.0.2 (#1311)
  Bump org.scoverage:scoverage-maven-plugin from 2.0.5 to 2.0.6 (#1308)
  Bump com.databricks:databricks-sdk-java from 0.21.0 to 0.36.0 (#1292)
sundarshankar89 pushed a commit to sundarshankar89/remorph that referenced this pull request Jan 2, 2025
Our current script returns false positives for stacked PRs.
Upgrading it to the latest one from ucx
sundarshankar89 pushed a commit to sundarshankar89/remorph that referenced this pull request Jan 3, 2025
Our current script returns false positives for stacked PRs.
Upgrading it to the latest one from ucx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants