Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly translate Snowflake REGEXP_SUBSTR #1312

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Properly translate Snowflake REGEXP_SUBSTR #1312

merged 4 commits into from
Dec 9, 2024

Conversation

vil1
Copy link
Contributor

@vil1 vil1 commented Dec 6, 2024

No description provided.

@vil1 vil1 requested a review from a team as a code owner December 6, 2024 10:32
Copy link

github-actions bot commented Dec 6, 2024

Coverage tests results

498 tests  +5   460 ✅ +5   5s ⏱️ -1s
  7 suites ±0    38 💤 ±0 
  7 files   ±0     0 ❌ ±0 

Results for commit 97378ed. ± Comparison against base commit 669312a.

♻️ This comment has been updated with latest results.

@vil1 vil1 self-assigned this Dec 6, 2024
Copy link
Contributor

@jimidle jimidle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vil1 vil1 requested a review from a team December 6, 2024 16:29
Copy link
Contributor

@ericvergnaud ericvergnaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vil1 vil1 added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 0281186 Dec 9, 2024
9 checks passed
@vil1 vil1 deleted the feat/regexp_extract branch December 9, 2024 14:38
ericvergnaud added a commit that referenced this pull request Dec 9, 2024
…ature/multiplexer/isolate-sqlglot-dependencies

* feature/multiplexer/refactor-transpiler-config:
  fix docs
  Fix incorrect script for no-pylint-disable (#1329)
  Refactor python transpiler code (#1314)
  Properly translate Snowflake REGEXP_SUBSTR (#1312)
  Prevent Dependabot from upgrading Databricks Connect. (#1322)
  Bump org.apache.maven.plugins:maven-jar-plugin from 2.4 to 3.4.2 (#1318)
  Bump com.lihaoyi:ujson_2.12 from 3.0.0-M2 to 4.0.2 (#1311)
  Bump org.scoverage:scoverage-maven-plugin from 2.0.5 to 2.0.6 (#1308)
  Bump com.databricks:databricks-sdk-java from 0.21.0 to 0.36.0 (#1292)
ericvergnaud added a commit that referenced this pull request Dec 9, 2024
…feature/multiplexer/rename-fixture

* feature/multiplexer/isolate-sqlglot-dependencies:
  fix docs
  Fix incorrect script for no-pylint-disable (#1329)
  Refactor python transpiler code (#1314)
  Properly translate Snowflake REGEXP_SUBSTR (#1312)
  Prevent Dependabot from upgrading Databricks Connect. (#1322)
  Bump org.apache.maven.plugins:maven-jar-plugin from 2.4 to 3.4.2 (#1318)
  Bump com.lihaoyi:ujson_2.12 from 3.0.0-M2 to 4.0.2 (#1311)
  Bump org.scoverage:scoverage-maven-plugin from 2.0.5 to 2.0.6 (#1308)
  Bump com.databricks:databricks-sdk-java from 0.21.0 to 0.36.0 (#1292)
ericvergnaud added a commit that referenced this pull request Dec 9, 2024
…lexer/create-launcher-from-cli

* feature/multiplexer/rename-fixture:
  fix docs
  Fix incorrect script for no-pylint-disable (#1329)
  Refactor python transpiler code (#1314)
  Properly translate Snowflake REGEXP_SUBSTR (#1312)
  Prevent Dependabot from upgrading Databricks Connect. (#1322)
  Bump org.apache.maven.plugins:maven-jar-plugin from 2.4 to 3.4.2 (#1318)
  Bump com.lihaoyi:ujson_2.12 from 3.0.0-M2 to 4.0.2 (#1311)
  Bump org.scoverage:scoverage-maven-plugin from 2.0.5 to 2.0.6 (#1308)
  Bump com.databricks:databricks-sdk-java from 0.21.0 to 0.36.0 (#1292)
sundarshankar89 added a commit to sundarshankar89/remorph that referenced this pull request Jan 2, 2025
sundarshankar89 added a commit to sundarshankar89/remorph that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants