-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to detect rows are written to the MockBackend
#292
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
406c8c9
Add `has_rows_written_for` method
JCZuurmond cb2fa68
Make rows written for optional
JCZuurmond e415d42
Remove mode from has_rows_written_for
JCZuurmond 3d63b11
Test has rows written for
JCZuurmond 7fccc7b
Test has rows written for different modes
JCZuurmond 6fa41ef
Update test names
JCZuurmond 270c311
Test for has rows_written_for after one write
JCZuurmond 73c6700
Test has no rows written for
JCZuurmond 79578ad
Implement has zero rows written for
JCZuurmond 8e226a6
Remove redundate whitelines
JCZuurmond 2cc3e38
Fix has_rows_written_for behaviour
JCZuurmond c362ffe
Extend the no rows written test and docs
JCZuurmond 5cc3f48
Fix table name
JCZuurmond da6e164
Extend test
JCZuurmond File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think there's a missing test for:
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I think I came up with this name, I'm not sure if there's something better? What troubles me is that the name is misleading for when
[]
was written: the plain-language description of this situation is that the table has been written but doesn't contain any rows for the table, but this doesn't really match the function name.Any ideas?