Add method to detect rows are written to the MockBackend
#292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ 35/35 passed, 7 flaky, 4 skipped, 9m4s total Flaky tests:
Running from acceptance #412 |
asnare
reviewed
Sep 19, 2024
There was a problem hiding this comment.
I think there's a missing test for:
- Write to a table (mode irrelevant)
- Write to a table: mode=overwrite, rows=[]
- Check that has-rows is true.
asnare
reviewed
Sep 19, 2024
| @@ -372,6 +372,18 @@ def rows_written_for(self, full_name: str, mode: str) -> list[DataclassInstance] | |||
| rows += stub_rows | |||
| return rows | |||
|
|
|||
| def has_rows_written_for(self, full_name: str) -> bool: | |||
There was a problem hiding this comment.
Although I think I came up with this name, I'm not sure if there's something better? What troubles me is that the name is misleading for when [] was written: the plain-language description of this situation is that the table has been written but doesn't contain any rows for the table, but this doesn't really match the function name.
Any ideas?
nfx
approved these changes
Sep 19, 2024
nfx
added a commit
that referenced
this pull request
Sep 19, 2024
* Added method to detect rows are written to the `MockBackend` ([#292](#292)). In this commit, the `MockBackend` class in the 'backends.py' file has been updated with a new method, 'has_rows_written_for', which allows for differentiation between a table that has never been written to and one with zero rows. This method checks if a specific table has been written to by iterating over the table stubs in the `_save_table` attribute and returning `True` if the given full name matches any of the stub full names. Additionally, the class has been supplemented with the `rows_written_for` method, which takes a table name and mode as input and returns a list of rows written to that table in the given mode. Furthermore, several new test cases have been added to test the functionality of the `MockBackend` class, including checking if the `has_rows_written_for` method correctly identifies when there are no rows written, when there are zero rows written, and when rows are written after the first and second write operations. These changes improve the overall testing coverage of the project and aid in testing the functionality of the `MockBackend` class. The new methods are accompanied by documentation strings that explain their purpose and functionality.
Merged
nfx
added a commit
that referenced
this pull request
Sep 19, 2024
* Added method to detect rows are written to the `MockBackend` ([#292](#292)). In this commit, the `MockBackend` class in the 'backends.py' file has been updated with a new method, 'has_rows_written_for', which allows for differentiation between a table that has never been written to and one with zero rows. This method checks if a specific table has been written to by iterating over the table stubs in the `_save_table` attribute and returning `True` if the given full name matches any of the stub full names. Additionally, the class has been supplemented with the `rows_written_for` method, which takes a table name and mode as input and returns a list of rows written to that table in the given mode. Furthermore, several new test cases have been added to test the functionality of the `MockBackend` class, including checking if the `has_rows_written_for` method correctly identifies when there are no rows written, when there are zero rows written, and when rows are written after the first and second write operations. These changes improve the overall testing coverage of the project and aid in testing the functionality of the `MockBackend` class. The new methods are accompanied by documentation strings that explain their purpose and functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this comment on motivation