-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prep and storage rename CLI #309
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 70.41% 73.90% +3.49%
==========================================
Files 130 134 +4
Lines 8065 8141 +76
==========================================
+ Hits 5679 6017 +338
+ Misses 1786 1488 -298
- Partials 600 636 +36
☔ View full report in Codecov by Sentry. |
- Optionally add CLI command integration tests in `cmd/functional_test.go` | ||
- Run `make generate` or `go generate ./...` | ||
- Add the swagger API unit test in `api/api_test.go` | ||
- Optionally add swagger API integration tests in `cmd/api_test.go` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hannahhoward @elijaharita
See if above makes sense to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it makes sense!
This adds support for belwo commands
Also updated
CONTRIBUTING.md
for how to do this correctly as listed belowresolves #292
handler/*
directoryhandler/*/interface.go
handler/*/interface.go
func _(){}
api/api.go
cmd/*
directorycmd/app.go
to register the new commandcmd/*_test.go
cmd/functional_test.go
make generate
orgo generate ./...
api/api_test.go
cmd/api_test.go