-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: How to delete or rename after singularity prep create #292
Labels
bug
Something isn't working
Comments
Deletion is a less common use case so it may come in the future. In fact different people has different expectation for deletion, i.e. a shallow deletion, delete with all metadata, delete with all metadata tracking, delete with all exported car files, etc. I'm going to leave such complexity to future. Renaming is, however, very easy to add |
Proposing below
|
That works! |
xinaxu
added a commit
that referenced
this issue
Sep 14, 2023
This adds support for belwo commands ``` singularity prep rename old new singularity storage rename old new ``` Also updated `CONTRIBUTING.md` for how to do this correctly as listed below resolves #292 - [x] Create a handler implementation under `handler/*` directory - [x] Make proper godoc comments for the implementation - [x] Add the handler function to the interface under `handler/*/interface.go` - [x] Update the MockHandler under `handler/*/interface.go` - [x] Create unit tests for this handler implementation - [x] Create a function to document the swagger API `func _(){}` - [x] Create corresponding API route handler in `api/api.go` - [x] Create a CLI command under `cmd/*` directory - [x] Update `cmd/app.go` to register the new command - [x] Add the CLI command unit test in one of `cmd/*_test.go` - [ ] Optionally add CLI command integration tests in `cmd/functional_test.go` - [x] Run `make generate` or `go generate ./...` - [x] Add the swagger API unit test in `api/api_test.go` - [ ] Optionally add swagger API integration tests in `cmd/api_test.go`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Steps to Reproduce
Use prep and forget to use --name
singularity prep create 2023nameofdataset
The only options available seem to be
Version
singularity v0.4.0-36ecfc5
Operating System
Linux
Database Backend
SQLite
Additional context
No response
The text was updated successfully, but these errors were encountered: