Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dat v14 -- breaking changes #1173

Merged
merged 20 commits into from
Mar 26, 2020
Merged

Dat v14 -- breaking changes #1173

merged 20 commits into from
Mar 26, 2020

Conversation

okdistribute
Copy link
Collaborator

@okdistribute okdistribute commented Mar 24, 2020

The network of dat v14 will not be compatible with earlier versions of dat. The .dat metadata file will still work, but older clients should upgrade to v14.

It will have big improvements:

  • Better connectivity: A better DHT and holepunching. The networking stack has been entirely rewritten. See https://github.com/hyperswarm/hyperswarm
  • Deprecating the dat share command. Now, dat share and dat sync do the same thing, so you no longer have to remember if your directory has a dat in it already.

@okdistribute okdistribute changed the title use hyperswarm Dat v14 -- breaking changes Mar 24, 2020
Copy link
Contributor

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll update the SDK to use hyperswarm too at some point in the near future. 💜

@decentral1se
Copy link

Got myself a fresh copy of node v12.16.1 and tried to npm install this branch and got confronted with a whole slew of errors. Here are the logs below. Probably I'm doing it wrong ❓

https://gist.github.com/decentral1se/8e45d5527c30414a8d2793b6e6a2999c

If I could get past this it'd be cool to test because I was struggling to get connectivity sorted from my homebrew here in the house. Thanks for the good work!

@okdistribute
Copy link
Collaborator Author

okdistribute commented Mar 24, 2020

@decentral1se ah looks like it's still trying to install discovery-swarm. can you rm -rf node_modules and rm package-lock.json, and then reinstall?

@decentral1se
Copy link

decentral1se commented Mar 24, 2020

Unfortunately, I still explode into flames: https://gist.github.com/decentral1se/90322a42bb8112239a64dedf7edc1e7d. Not sure what I'm doing TBH :)

@okdistribute
Copy link
Collaborator Author

@decentral1se Oh I figured it out, dat-doctor is installing discovery-swarm.

@okdistribute
Copy link
Collaborator Author

okdistribute commented Mar 24, 2020

okay @decentral1se this should be ready for testing now, my apologies

@decentral1se
Copy link

decentral1se commented Mar 24, 2020

Yep that installs! I could share some test folders! It's a bit hard to test with friends who can't go through this installation procedure to check if we can share what was problematic to share before. Also the dat doctor is gone now, so I can't check if those issues are resolved (was seeing a "cannot find public ip / port" message) :) If this could go out on a new release of dat-desktop, I'd definitely be able to give it more testing.

@christianbundy
Copy link

christianbundy commented Mar 24, 2020

Installs and passes test over here. 🎉


(If you'd like any help testing something, please let me know. I've been meaning to spend more time checking out this stack.)

@okdistribute okdistribute merged commit 63ea6c1 into master Mar 26, 2020
@okdistribute okdistribute deleted the dat-nodev4 branch March 26, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants