-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport: bitcoin#18867, #19247, #19222, #18363, #18190, #18393, partial #18047, #18314, #19143 (fuzzing harness backports: part 3) #4886
Conversation
This pull request has conflicts, please rebase. |
This pull request has conflicts, please rebase. |
764e2c7
to
7788006
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK for merging via merge commit
utACK for merging via merge commit
@PastaPastaPasta Thanks for reviewing. Your response was a little vague though. My only question is, could you let us know if you will utACK this for merging via a merge commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't compile:
In file included from test/fuzz/addition_overflow.cpp:7:
./test/fuzz/util.h:265:13: error: no matching function for call to 'AdditionOverflow'
if (AdditionOverflow((uint64_t)fuzzed_file->m_offset, random_bytes.size())) {
^~~~~~~~~~~~~~~~
./test/fuzz/util.h:131:20: note: candidate template ignored: deduced conflicting types for parameter 'T' ('unsigned long long' vs. 'unsigned long')
[[nodiscard]] bool AdditionOverflow(const T i, const T j) noexcept
^
./test/fuzz/util.h:276:13: error: no matching function for call to 'AdditionOverflow'
if (AdditionOverflow(fuzzed_file->m_offset, n)) {
^~~~~~~~~~~~~~~~
./test/fuzz/util.h:131:20: note: candidate template ignored: deduced conflicting types for parameter 'T' ('long long' vs. 'long')
[[nodiscard]] bool AdditionOverflow(const T i, const T j) noexcept
^
2 errors generated.
dropping 60aa00a helps
…e/CSubNet related functions (netaddress.h)
…a (utxo_snapshot). Increase fuzzing coverage
…File, LoadExternalBlockFile and other FILE* consumers
…ilarity AdditionOverflow is a template function that expects both inputs to explicitly be of the same type
…evhttp and related functions
…mbRiceEncode/GolombRiceDecode)
…in MultiplicationOverflow(...) fuzzing harness
…}SHA{1,256,512}, CRIPEMD160, CSipHasher, etc.
…binary per message type for optimal results when using coverage-guided fuzzing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK for merging via merge commit
Depends on