backport: bitcoin#18417, #18521, #18529, #18176, #18423, #17926, #18353, #18407, #18455, #18565, #18867 (fuzzing harness backports: part 2)

[kwvg]

Depends on

• backport: bitcoin#16240, #18923, #19277, #20016, #20671 (auxiliary backports: part 5) #4830

Additional Notes

• See backport: bitcoin#15934, #15864, #19188, #18338, #19413, #18571, #18575 (deglobalization part 3) #4844 (comment)

[github-actions]

This pull request has conflicts, please rebase.

[github-actions]

This pull request has conflicts, please rebase.

[github-actions]

This pull request has conflicts, please rebase.

[UdjinM6]

CI complains:

In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:13: error: no matching function for call to 'swap'
            std::swap(table[last_loc], e);
            ^~~~~~~~~
test/fuzz/cuckoocache.cpp:43:26: note: in instantiation of member function 'CuckooCache::cache<bool, (anonymous namespace)::RandomHasher>::insert' requested here
            cuckoo_cache.insert(fuzzed_data_provider.ConsumeBool());

[UdjinM6]

LGTM (compiles locally with --enable-fuzz), utACK

[PastaPastaPasta]

  CXX      test/fuzz/asmap_direct-asmap_direct.o
test/fuzz/asmap_direct.cpp:30:25: error: variable 'sep_pos' may be uninitialized when used here [-Werror,-Wconditional-uninitialized]
    if (buffer.size() - sep_pos - 1 > 128) return; // At most 128 bits in IP address
                        ^~~~~~~
test/fuzz/asmap_direct.cpp:17:19: note: initialize the variable 'sep_pos' to silence this warning
    size_t sep_pos;
                  ^
                   = 0
1 error generated.
make[2]: *** [test/fuzz/asmap_direct-asmap_direct.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/Library/Developer/CommandLineTools/usr/bin/clang -mmacosx-version-min=10.15 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk -O2  -std=c89 -pedantic -Wno-long-long -Wnested-externs -Wshadow -Wstrict-prototypes -Wundef -Wno-overlength-strings -Wall -Wno-unused-function -Wextra -Wcast-align -Wconditional-uninitialized -fvisibility=hidden  -pipe -O2  -L/Users/pasta/workspace/dash/depends/aarch64-apple-darwin21.5.0/lib  gen_context.o -o gen_context
./gen_context
test/fuzz/addrdb.cpp:21:21: error: unused variable 'ban_entry' [-Werror,-Wunused-variable]
    const CBanEntry ban_entry = [&] {
                    ^
1 error generated.
make[2]: *** [test/fuzz/addrdb-addrdb.o] Error 1
  CC       src/libsecp256k1_la-secp256k1.lo
  CCLD     libsecp256k1.la
make[1]: *** [check-recursive] Error 1
make: *** [check-recursive] Error 1
                                                                                                                                                 

[PastaPastaPasta]

utACK for merging via merge commit

Note: there are build errors when using --enable-fuzz and --enable-werror. I have asked @kittywhiskers to create an issue to track this.