Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump js from 0.6.7 to 0.7.0 in /pkgs/test #2168

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 5, 2024

Bumps js from 0.6.7 to 0.7.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [js](https://github.com/dart-lang/sdk/tree/main/pkg) from 0.6.7 to 0.7.0.
- [Changelog](https://github.com/dart-lang/sdk/blob/main/CHANGELOG.md)
- [Commits](https://github.com/dart-lang/sdk/commits/0.7.0.0/pkg)

---
updated-dependencies:
- dependency-name: js
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dart Pull requests that update Dart code dependencies Pull requests that update a dependency file labels Jan 5, 2024
@dependabot dependabot bot requested a review from natebosch January 5, 2024 03:36
@natebosch
Copy link
Member

@srujzs - Do you know if it should be safe to expand the constraint and allow >=0.6.0 <0.8.0?

@jakemac53
Copy link
Contributor

I am curious what the actual breaking changes are here? The changelog doesn't list anything obviously breaking https://pub.dev/packages/js/changelog#070?

@srujzs
Copy link

srujzs commented Jan 5, 2024

I am curious what the actual breaking changes are here? The changelog doesn't list anything obviously breaking https://pub.dev/packages/js/changelog#070?

It's a bit subtle (I'll amend the changelog to be more specific), but this is the relevant comment:

Moved annotations to single location in dart:_js_annotations. This makes it easier to avoid collisions with dart:js_interop's @JS.

We have two @JS annotations - one that is visible through package:web and the other through dart:js_interop. We did this to avoid a breaking change in the meaning of the annotation (particularly around soundness of return types). Due to the way Dart resolves definitions, the package definition is always preferred over an SDK definition. This is bad, because users who import both interop libraries and use @JS will silently use the package:js definition. To avoid this, we added a change to move the annotation from package:js to a Dart library (dart:_js_annotations) and export it so that a collision actually occurs. However, any code that was importing both libraries and using @JS will now break if they had a js: ^0.6.0 constraint. So, I opted to make this a breaking change.

Do you know if it should be safe to expand the constraint and allow >=0.6.0 <0.8.0?

It should likely be >=0.6.4 <0.8.0 since the previous 0.6.X versions don't include stuff that this package uses like @staticInterop. That modified constraint should be okay I believe since package:test itself doesn't have any collisions of @JS. Packages that depend on package:test can use any package versions between that version range.

@kevmoo
Copy link
Member

kevmoo commented Jan 10, 2024

PTAL

@kevmoo kevmoo merged commit fe3102e into master Jan 10, 2024
35 checks passed
@kevmoo kevmoo deleted the dependabot/pub/pkgs/test/js-0.7.0 branch January 10, 2024 19:44
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jan 30, 2024
… mime, mockito, test, tools, vector_math

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/46d5033..03386ba):
  03386ba  2024-01-23  Albert Kaiser  Add missing curly braces in README.md (dart-archive/args#261)

csslib (https://github.com/dart-lang/csslib/compare/1ad2d1e..ec86ee5):
  ec86ee5  2024-01-09  Kevin Moore  Require Dart 3.0, update and fix lints (dart-archive/csslib#194)

ecosystem (https://github.com/dart-lang/ecosystem/compare/1e2785d..9ee08a4):
  9ee08a4  2024-01-29  Moritz  Add `ignore` flag to health workflows (dart-lang/ecosystem#218)
  a283d70  2024-01-17  Moritz  Make health testable (dart-lang/ecosystem#224)
  f61a550  2024-01-16  Moritz  Enable experiments for health (dart-lang/ecosystem#226)
  c81f25c  2024-01-16  Moritz  Add submodule support to `publish.yaml` (dart-lang/ecosystem#225)
  b51c356  2024-01-12  Moritz  Add submodules support to `health.yaml` (dart-lang/ecosystem#223)
  d7aaecb  2024-01-10  Moritz  Run `health.yaml` for bots (dart-lang/ecosystem#222)
  971c733  2024-01-10  Moritz  Don't write the failure string when skipping (dart-lang/ecosystem#220)

html (https://github.com/dart-lang/html/compare/06bc148..910f6d7):
  910f6d7  2024-01-26  Kevin Moore  Update lints, require Dart 3.2 (dart-archive/html#236)
  aaf7d1a  2024-01-25  Kevin Moore  blast_repo fixes (dart-archive/html#235)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/ae48489..491f7c6):
  491f7c6  2024-01-24  Kevin Moore  Update lints, require Dart 3.2 (dart-lang/http_multi_server#63)
  0df95e0  2024-01-24  Kevin Moore  blast_repo fixes (dart-lang/http_multi_server#62)

logging (https://github.com/dart-lang/logging/compare/4d35a4e..e04942d):
  e04942d  2024-01-18  Kevin Moore  update min SDK and deps (dart-archive/logging#155)
  a03a946  2024-01-18  Craig Labenz  Hierarchical logging documentation (dart-archive/logging#146)
  439ec80  2024-01-18  Kevin Moore  blast_repo fixes (dart-archive/logging#154)

mime (https://github.com/dart-lang/mime/compare/ca9f059..99fbdcc):
  99fbdcc  2024-01-24  Kevin Moore  Update to latest lints, require Dart 3.2 (dart-archive/mime#114)

mockito (https://github.com/dart-lang/mockito/compare/e15e000..0422551):
  0422551  2024-01-10  Oleh Prypin  Ignore "must_be_immutable" warning in generated files.

test (https://github.com/dart-lang/test/compare/846d73e..6700049):
  6700049d  2024-01-29  Nate Bosch  Prepare to publish package:checks (dart-lang/test#2178)
  a5c4f010  2024-01-24  Nate Bosch  Use a raw string for console logging with path (dart-lang/test#2177)
  fe3102ee  2024-01-10  dependabot[bot]  Bump js from 0.6.7 to 0.7.0 in /pkgs/test (dart-lang/test#2168)
  c709cde0  2024-01-10  Jacob MacDonald  fix a bug where test html files were not created in precompiled mode (dart-lang/test#2170)
  0eddae47  2024-01-09  Nate Bosch  Document the silent reporter (dart-lang/test#2163)

tools (https://github.com/dart-lang/tools/compare/8ffc077..f6e67f2):
  f6e67f2  2024-01-29  Elias Yishak  Fix logic for first run to fix `shouldShowMessage` behavior (dart-lang/tools#228)
  b97bd5c  2024-01-29  Elias Yishak  Checking for devtools config file for opt out (dart-lang/tools#227)

vector_math (https://github.com/google/vector_math.dart/compare/38a00c3..cb976c7):
  cb976c7  2024-01-28  Andrew Brampton  Update README.md to show how to use vector_math_64. (google/vector_math.dart#312)
  d99c903  2024-01-25  Andrew Brampton  Added a toString, operator == and hashCode to the Quad class. (google/vector_math.dart#311)

Change-Id: Ie42ec078b7b4d408d5167e38f05f1f37b754afb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/349301
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dart Pull requests that update Dart code dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants