Make health testable #224

mosuem · 2024-01-15T12:07:26Z

Add golden test for health.yaml, as the complexity and the impact of changes starts to get high enough to warrant the work. The test consists of running the health workflow against a simulated monorepo in test_data.

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

This reverts commit 2bacc71.

github-actions · 2024-01-15T12:12:02Z

PR Health

Breaking changes ✔️

Details

Package	Change	Current Version	New Version	Needed Version	Looking good?
firehose	Breaking	0.5.3	0.6.0	0.6.0	✔️

Changelog Entry ✔️

Details

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️

Details

File	Coverage
pkgs/firehose/bin/health.dart	💔 Not covered
pkgs/firehose/lib/firehose.dart	💚 29 %
pkgs/firehose/lib/src/github.dart	💚 68 % ⬆️ 9 %
pkgs/firehose/lib/src/health/changelog.dart	💚 97 %
pkgs/firehose/lib/src/health/coverage.dart	💚 76 % ⬆️ 108 %
pkgs/firehose/lib/src/health/health.dart	💚 92 %
pkgs/firehose/lib/src/health/license.dart	💚 100 %
pkgs/firehose/lib/src/utils.dart	💚 83 % ⬆️ 328 %
pkgs/firehose/test_data/base_test_repo/pkgs/package1/bin/package1.dart	💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package1/lib/package1.dart	💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package1/test/package1_test.dart	💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package2/bin/package2.dart	💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package2/lib/package2.dart	💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package2/test/package2_test.dart	💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package3/bin/package3.dart	💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package3/lib/package3.dart	💔 Not covered
pkgs/firehose/test_data/base_test_repo/pkgs/package3/test/package3_test.dart	💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package1/bin/package1.dart	💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package1/lib/package1.dart	💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package1/test/package1_test.dart	💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package2/bin/package2.dart	💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package2/lib/anotherLib.dart	💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package2/lib/package2.dart	💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package2/test/package2_test.dart	💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package3/bin/package3.dart	💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package3/lib/package3.dart	💔 Not covered
pkgs/firehose/test_data/test_repo/pkgs/package3/test/package3_test.dart	💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check

License Headers ⚠️

Details

// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
pkgs/firehose/test_data/base_test_repo/pkgs/package1/bin/package1.dart
pkgs/firehose/test_data/base_test_repo/pkgs/package1/lib/package1.dart
pkgs/firehose/test_data/base_test_repo/pkgs/package1/test/package1_test.dart
pkgs/firehose/test_data/base_test_repo/pkgs/package2/lib/package2.dart
pkgs/firehose/test_data/base_test_repo/pkgs/package2/test/package2_test.dart
pkgs/firehose/test_data/base_test_repo/pkgs/package3/bin/package3.dart
pkgs/firehose/test_data/base_test_repo/pkgs/package3/lib/package3.dart
pkgs/firehose/test_data/base_test_repo/pkgs/package3/test/package3_test.dart
pkgs/firehose/test_data/test_repo/pkgs/package1/bin/package1.dart
pkgs/firehose/test_data/test_repo/pkgs/package1/lib/package1.dart
pkgs/firehose/test_data/test_repo/pkgs/package1/test/package1_test.dart
pkgs/firehose/test_data/test_repo/pkgs/package2/lib/anotherLib.dart
pkgs/firehose/test_data/test_repo/pkgs/package2/lib/package2.dart
pkgs/firehose/test_data/test_repo/pkgs/package2/test/package2_test.dart
pkgs/firehose/test_data/test_repo/pkgs/package3/bin/package3.dart
pkgs/firehose/test_data/test_repo/pkgs/package3/lib/package3.dart
pkgs/firehose/test_data/test_repo/pkgs/package3/test/package3_test.dart

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check

Package publish validation ✔️

Details

Package	Version	Status
package:firehose	0.6.0	ready to publish
package:dart_flutter_team_lints	2.1.1	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

github-actions · 2024-01-15T12:48:35Z

Package publishing

Package	Version	Status	Publish tag (post-merge)
package:firehose	0.6.0	ready to publish	`firehose-v0.6.0`
package:dart_flutter_team_lints	2.1.1	already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

mosuem · 2024-01-16T09:11:32Z

.github/workflows/health_base.yaml

@@ -118,7 +117,7 @@ jobs:
        if: ${{ '$action_state' == 1 }}

      - name: Upload coverage to Coveralls
-        if: ${{ inputs.upload_coverage }}
+        if: ${{ inputs.upload_coverage && inputs.check == 'coverage' }}


This is a bugfix, before, coverage was always uploaded as upload_coverage defaults to true.

… mime, mockito, test, tools, vector_math Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/46d5033..03386ba): 03386ba 2024-01-23 Albert Kaiser Add missing curly braces in README.md (dart-archive/args#261) csslib (https://github.com/dart-lang/csslib/compare/1ad2d1e..ec86ee5): ec86ee5 2024-01-09 Kevin Moore Require Dart 3.0, update and fix lints (dart-archive/csslib#194) ecosystem (https://github.com/dart-lang/ecosystem/compare/1e2785d..9ee08a4): 9ee08a4 2024-01-29 Moritz Add `ignore` flag to health workflows (dart-lang/ecosystem#218) a283d70 2024-01-17 Moritz Make health testable (dart-lang/ecosystem#224) f61a550 2024-01-16 Moritz Enable experiments for health (dart-lang/ecosystem#226) c81f25c 2024-01-16 Moritz Add submodule support to `publish.yaml` (dart-lang/ecosystem#225) b51c356 2024-01-12 Moritz Add submodules support to `health.yaml` (dart-lang/ecosystem#223) d7aaecb 2024-01-10 Moritz Run `health.yaml` for bots (dart-lang/ecosystem#222) 971c733 2024-01-10 Moritz Don't write the failure string when skipping (dart-lang/ecosystem#220) html (https://github.com/dart-lang/html/compare/06bc148..910f6d7): 910f6d7 2024-01-26 Kevin Moore Update lints, require Dart 3.2 (dart-archive/html#236) aaf7d1a 2024-01-25 Kevin Moore blast_repo fixes (dart-archive/html#235) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/ae48489..491f7c6): 491f7c6 2024-01-24 Kevin Moore Update lints, require Dart 3.2 (dart-lang/http_multi_server#63) 0df95e0 2024-01-24 Kevin Moore blast_repo fixes (dart-lang/http_multi_server#62) logging (https://github.com/dart-lang/logging/compare/4d35a4e..e04942d): e04942d 2024-01-18 Kevin Moore update min SDK and deps (dart-archive/logging#155) a03a946 2024-01-18 Craig Labenz Hierarchical logging documentation (dart-archive/logging#146) 439ec80 2024-01-18 Kevin Moore blast_repo fixes (dart-archive/logging#154) mime (https://github.com/dart-lang/mime/compare/ca9f059..99fbdcc): 99fbdcc 2024-01-24 Kevin Moore Update to latest lints, require Dart 3.2 (dart-archive/mime#114) mockito (https://github.com/dart-lang/mockito/compare/e15e000..0422551): 0422551 2024-01-10 Oleh Prypin Ignore "must_be_immutable" warning in generated files. test (https://github.com/dart-lang/test/compare/846d73e..6700049): 6700049d 2024-01-29 Nate Bosch Prepare to publish package:checks (dart-lang/test#2178) a5c4f010 2024-01-24 Nate Bosch Use a raw string for console logging with path (dart-lang/test#2177) fe3102ee 2024-01-10 dependabot[bot] Bump js from 0.6.7 to 0.7.0 in /pkgs/test (dart-lang/test#2168) c709cde0 2024-01-10 Jacob MacDonald fix a bug where test html files were not created in precompiled mode (dart-lang/test#2170) 0eddae47 2024-01-09 Nate Bosch Document the silent reporter (dart-lang/test#2163) tools (https://github.com/dart-lang/tools/compare/8ffc077..f6e67f2): f6e67f2 2024-01-29 Elias Yishak Fix logic for first run to fix `shouldShowMessage` behavior (dart-lang/tools#228) b97bd5c 2024-01-29 Elias Yishak Checking for devtools config file for opt out (dart-lang/tools#227) vector_math (https://github.com/google/vector_math.dart/compare/38a00c3..cb976c7): cb976c7 2024-01-28 Andrew Brampton Update README.md to show how to use vector_math_64. (google/vector_math.dart#312) d99c903 2024-01-25 Andrew Brampton Added a toString, operator == and hashCode to the Quad class. (google/vector_math.dart#311) Change-Id: Ie42ec078b7b4d408d5167e38f05f1f37b754afb0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/349301 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>

mosuem added 20 commits January 8, 2024 16:08

Add ignore flag to health workflows

0c31c59

Switch to glob

6b487f8

Fix multiline

ee185bc

Add default glob

7a9ab59

Delete multiline

cbb7266

Fix errors

9f84be4

Fix health commenting

6f1c834

Merge branch 'main' into addIgnoredFilesToHealth

128af77

Propagate ignore

9919dd0

Switch to specific ignores

c7073d5

Add defaults

2bacc71

Add test repos

4e15f4d

Start adding health tests

0962184

Add golden files

da5d59b

Fix changelog

05e0dc9

Fix coverage

f623f41

Fix breaking

93a0d44

More fixes

989649e

Revert "Add defaults"

b201f0b

This reverts commit 2bacc71.

Remove ignores

1bfb902

github-actions bot added package:firehose type-infra A repository infrastructure change or enhancement labels Jan 15, 2024

mosuem added 2 commits January 15, 2024 13:10

Remove ignores from yamls

854a8c8

Remove from firehose

554e975

mosuem added 5 commits January 15, 2024 13:12

Remove from github

f9f760d

Remove from repo

ab836e8

Add changelog

2ec6d84

Move goldens

464d11b

Fix glob issue

dfcb177

Add test data to pubignore

285edbd

mosuem added 10 commits January 15, 2024 13:50

Switch SDK version

95f2a62

Move stuff around

e9b3465

Fix imports

27e5f2a

Give test a name

5ccd5a5

Sort license files

ae6bac7

Switch debug messages

b46ff67

Add debug string

47ea57e

Add debug

75551e9

Add activate global

0ef7cb3

Remove debugging

5916e77

mosuem requested a review from devoncarew January 15, 2024 15:38

mosuem marked this pull request as ready for review January 15, 2024 15:40

mosuem added the skip-do-not-submit-check label Jan 15, 2024

Fix coverage upload

b8e0c88

mosuem commented Jan 16, 2024

View reviewed changes

mosuem added 2 commits January 16, 2024 13:20

Merge branch 'main' into makeHealthTestable

29c04b4

fix erros

6bad589

devoncarew approved these changes Jan 16, 2024

View reviewed changes

mosuem merged commit a283d70 into main Jan 17, 2024
22 checks passed

mosuem deleted the makeHealthTestable branch January 17, 2024 13:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make health testable #224

Make health testable #224

mosuem commented Jan 15, 2024 •

edited

Loading

github-actions bot commented Jan 15, 2024 •

edited

Loading

github-actions bot commented Jan 15, 2024

mosuem Jan 16, 2024

Make health testable #224

Make health testable #224

Conversation

mosuem commented Jan 15, 2024 • edited Loading

github-actions bot commented Jan 15, 2024 • edited Loading

PR Health

Breaking changes ✔️

Changelog Entry ✔️

Coverage ⚠️

License Headers ⚠️

Package publish validation ✔️

github-actions bot commented Jan 15, 2024

Package publishing

mosuem Jan 16, 2024

Choose a reason for hiding this comment

mosuem commented Jan 15, 2024 •

edited

Loading

github-actions bot commented Jan 15, 2024 •

edited

Loading