-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dart editor find box holds focus #488
Comments
Well that's not good! A few questions... * Is there anything in your .log file? (You can find it in the workspace/.metadata directory in your editor install dir. Alternatively you can send a feedback report and select the "Send additional data" button. If the error was recent, we should get traces in the report.) * What OS are you using? * Is this reproducible? Thanks for the report! |
This comment was originally written by [email protected] Yes, I have just reproduced it again. Seems to take just typing a bunch of random junk quickly in the text box for it to happen. |
Cool. Thanks for the follow-up. I'll see if I can repro and get cracking on a fix. |
This got re-reported here: http://code.google.com/p/dart/issues/detail?id=749. Fix: http://codereview.chromium.org/8893018/ is in flight. |
Fixed!: http://codereview.chromium.org/8893018/. Added Fixed label. |
This comment was originally written by [email protected] Actually, this bug has come back and I'm hitting quite frequently again, so I'm reactivating this. Added Triaged label. |
OK, bummer. I'll try and repro today. Thanks for re-opening! |
I'm not having luck reproducing this... Any hints would be greatly appreciated! (BTW: I'm using gnome on ubuntu.) |
Issue #1910 has been merged into this issue. |
This comment was originally written by [email protected] I don't remember exactly what I was doing before I got into this state, and it isn't happening nearly as much as before, but it definitely was happening, to the point where I would need to restart the editor approximately every half hour. |
I like where you're going with this... I'll look a little more and think about some instrumentation as you suggest. Moreover, I could add some corrective code to unwedge the searchbox when the state is detected. Not a long term solution but might be a good temporary (and expedient) measure. As for the inconvenience, I'm truly sorry about that. Sucks. And you can blame me :(. I'm good for a beer (if not a fix ;)). |
This comment was originally written by [email protected] Not a problem. It is still quite usable. No worries. |
Added OpSys-Linux label. |
Is this still an issue? I added some extra error-handling that, fingers crossed, I hope mitigates the issue. Let me know if it's still cropping up! |
Please re-open if this crops up again and there is a way to reproduce the problem. Added Fixed label. |
- Instead of using the raw runtime type that DDC uses for its type checks, use a WrappedType that correctly implements Type's interface. - Compile class literals to wrap the type in a WrappedType. - Make Object.runtimeType() do the same thing. Fixes #488. Fixes #511. [email protected] Review URL: https://codereview.chromium.org/1944483002 .
Changes: ``` > git log --format="%C(auto) %h %s" a70b93a..37951d1 https://dart.googlesource.com/markdown.git/+/37951d1 Fix an ImageSyntax issue (#493) https://dart.googlesource.com/markdown.git/+/29196b7 Refactor CodeBlockSyntax (#488) https://dart.googlesource.com/markdown.git/+/32c52d6 benchmark: use Stopwatch over DateTime for benchmarking (#491) https://dart.googlesource.com/markdown.git/+/0a7a531 Refactor ATX headings (#486) https://dart.googlesource.com/markdown.git/+/2fab846 some cleanup (#489) https://dart.googlesource.com/markdown.git/+/816dd87 Refactor CodeSyntax (#487) https://dart.googlesource.com/markdown.git/+/a529e58 Fix HTML escape issues (#484) ``` Diff: https://dart.googlesource.com/markdown.git/+/a70b93a1a004cc1da04a3e3ea59821ef8391e0d6~..37951d151750acfae756b2e466f563c1c5119b3d/ Change-Id: I3f8419477df2280801be3cf9251e003f6c482984 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270224 Commit-Queue: Samuel Rawlins <[email protected]> Auto-Submit: Devon Carew <[email protected]> Commit-Queue: Devon Carew <[email protected]> Reviewed-by: Samuel Rawlins <[email protected]>
This issue was originally filed by [email protected]
I choose "Open Declaration", which put the caret in the Find box, but after this it is impossible to click back in the editor window and resume typing because the focus stays in the find box. The only way seems to be to restart the editor.
The text was updated successfully, but these errors were encountered: