Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CanvasWrappingImplementation should not be public in dart:html #487

Closed
DartBot opened this issue Nov 16, 2011 · 1 comment
Closed

CanvasWrappingImplementation should not be public in dart:html #487

DartBot opened this issue Nov 16, 2011 · 1 comment
Assignees
@jacob314

Comments

@DartBot
Copy link

DartBot commented Nov 16, 2011

This issue was originally filed by [email protected]

Currently classes like CanvasWrappingImplementation, or HashChangeEventWrappingImplementation are public classes in dart:html. These end up appearing in the completion lists of Dart editor and are a bit distracting.
@jacob314
Copy link
Member

jacob314 commented Dec 1, 2011

Fixed by switching to dart:html and dart:htmlimpl

Added Fixed label.

This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
copybara-service bot pushed a commit that referenced this issue Nov 16, 2022
@devoncarew
Bump markdown to 37951d151750acfae756b2e466f563c1c5119b3d
fcc933a 
Changes:
```
> git log --format="%C(auto) %h %s" a70b93a..37951d1
 https://dart.googlesource.com/markdown.git/+/37951d1 Fix an ImageSyntax issue (#493)
 https://dart.googlesource.com/markdown.git/+/29196b7 Refactor CodeBlockSyntax (#488)
 https://dart.googlesource.com/markdown.git/+/32c52d6 benchmark: use Stopwatch over DateTime for benchmarking (#491)
 https://dart.googlesource.com/markdown.git/+/0a7a531 Refactor ATX headings (#486)
 https://dart.googlesource.com/markdown.git/+/2fab846 some cleanup (#489)
 https://dart.googlesource.com/markdown.git/+/816dd87 Refactor CodeSyntax (#487)
 https://dart.googlesource.com/markdown.git/+/a529e58 Fix HTML escape issues (#484)

```

Diff: https://dart.googlesource.com/markdown.git/+/a70b93a1a004cc1da04a3e3ea59821ef8391e0d6~..37951d151750acfae756b2e466f563c1c5119b3d/
Change-Id: I3f8419477df2280801be3cf9251e003f6c482984
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270224
Commit-Queue: Samuel Rawlins <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacob314 jacob314

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacob314 @DartBot