Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List of existing librarys which deviate from style guidelines #340

Closed
DartBot opened this issue Nov 4, 2011 · 6 comments
Closed

List of existing librarys which deviate from style guidelines #340

DartBot opened this issue Nov 4, 2011 · 6 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant

Comments

@DartBot
Copy link

DartBot commented Nov 4, 2011

This issue was originally filed by @chrisbu

Please provide any additional information below.

A number of pre-existing libraries may need modifying to meet the expectations given in the dart style guidelines here: http://www.dartlang.org/articles/style-guide/

First one is:
Style recommendation:
AVOID boolean arguments unless their meaning is completely obvious.

  1. xmlHttpRequest.open("GET",url,false); //what does false mean?
  2. new Timer(callback, ms, false); //what does false mean?
@DartBot
Copy link
Author

DartBot commented Nov 4, 2011

This comment was originally written by [email protected]

Added Area-Library label.

@DartBot
Copy link
Author

DartBot commented Nov 4, 2011

This comment was originally written by [email protected]

Issue #268 has been merged into this issue.

@DartBot
Copy link
Author

DartBot commented Nov 8, 2011

This comment was originally written by [email protected]

Added Triaged label.

@DartBot
Copy link
Author

DartBot commented Dec 8, 2011

This comment was originally written by [email protected]

I think it's better to use separate bugs for each of the APIs that is proposed to change (unless they are closely related), just because it will be easier to track the decision and work.

@DartBot
Copy link
Author

DartBot commented Mar 5, 2012

This comment was originally written by @chrisbu

I can see that commit 4945 has addressed the "Timer" issue.

@madsager
Copy link
Contributor

Thanks for the bug report. I'm doing a bit of bug cleanup. This report is too broad to really take action on and I'm therefore closing it. Please file separate bugs for individual APIs. Thanks.

Added AssumedStale label.

@DartBot DartBot added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant labels Sep 26, 2012
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
copybara-service bot pushed a commit that referenced this issue Mar 14, 2023
@devoncarew
[deps] rev dartdoc, http, matcher, shelf, test, webdev, yaml_edit
fcb8f80 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4):
  7fde7a4d  2023-03-13  dependabot[bot]  Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363)

http (https://github.com/dart-lang/http/compare/805a147..74f9d3d):
  74f9d3d  2023-03-09  Brian Quinlan  Add conformances test that verify that the Client works in Isolates (#889)
  ee03604  2023-03-09  Brian Quinlan  Add a flag to allow the default Client to be tree shaken away. (#868)
  2039fb3  2023-03-09  Brian Quinlan  Fix a reference count race with forwarded delegates. (#888)

matcher (https://github.com/dart-lang/matcher/compare/c1a0704..985e4ef):
  985e4ef  2023-03-10  Sigurd Meldgaard  Improve mismatch description of `contains` (#206)
  5bc765d  2023-03-09  Nate Bosch  Copy expect and async matchers from test package (#210)

shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4):
  9a792b4  2023-03-13  Kevin Moore  Update format for latest v3 SDK (#340)
  c8094b7  2023-03-13  Kevin Moore  Update no-response.yml - once a day (#339)

test (https://github.com/dart-lang/test/compare/3ba78f1..0e5c028):
  0e5c028d  2023-03-10  Nate Bosch  Only use environment variable for chrome (#1970)
  0b08d704  2023-03-08  Nate Bosch  Add a hooks_testing library (#1952)
  aacee2c7  2023-03-08  Nate Bosch  Retry filesystem deletes (#1965)

webdev (https://github.com/dart-lang/webdev/compare/cfe9753..49013b8):
  49013b8  2023-03-09  Elliott Brooks (she/her)  [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026)
  c8d4439  2023-03-09  Elliott Brooks (she/her)  Support `Set` inspection in DWDS (#2024)
  442639d  2023-03-08  Elliott Brooks (she/her)  Handle unexpected extension debugger disconnection events without crashing app (#2021)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3):
  fbc5cb3  2023-03-09  Kevin Moore  Require Dart 2.19, update to latest lints
  c9e82f0  2023-03-09  Mohamed Ishad  Fix YamlEditor.update method leaving trailing spaces at eol (#42)

Change-Id: Idc785347448e6a56e26d9d46b3666440d59c22de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288801
Auto-Submit: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 14, 2023
@devoncarew
Revert "[deps] rev dartdoc, http, matcher, shelf, test, webdev, yaml_…
107578b 
…edit"

This reverts commit fcb8f80.

Reason for revert: google3 roll failure

Original change's description:
> [deps] rev dartdoc, http, matcher, shelf, test, webdev, yaml_edit
>
> Revisions updated by `dart tools/rev_sdk_deps.dart`.
>
> dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4):
>   7fde7a4d  2023-03-13  dependabot[bot]  Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363)
>
> http (https://github.com/dart-lang/http/compare/805a147..74f9d3d):
>   74f9d3d  2023-03-09  Brian Quinlan  Add conformances test that verify that the Client works in Isolates (#889)
>   ee03604  2023-03-09  Brian Quinlan  Add a flag to allow the default Client to be tree shaken away. (#868)
>   2039fb3  2023-03-09  Brian Quinlan  Fix a reference count race with forwarded delegates. (#888)
>
> matcher (https://github.com/dart-lang/matcher/compare/c1a0704..985e4ef):
>   985e4ef  2023-03-10  Sigurd Meldgaard  Improve mismatch description of `contains` (#206)
>   5bc765d  2023-03-09  Nate Bosch  Copy expect and async matchers from test package (#210)
>
> shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4):
>   9a792b4  2023-03-13  Kevin Moore  Update format for latest v3 SDK (#340)
>   c8094b7  2023-03-13  Kevin Moore  Update no-response.yml - once a day (#339)
>
> test (https://github.com/dart-lang/test/compare/3ba78f1..0e5c028):
>   0e5c028d  2023-03-10  Nate Bosch  Only use environment variable for chrome (#1970)
>   0b08d704  2023-03-08  Nate Bosch  Add a hooks_testing library (#1952)
>   aacee2c7  2023-03-08  Nate Bosch  Retry filesystem deletes (#1965)
>
> webdev (https://github.com/dart-lang/webdev/compare/cfe9753..49013b8):
>   49013b8  2023-03-09  Elliott Brooks (she/her)  [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026)
>   c8d4439  2023-03-09  Elliott Brooks (she/her)  Support `Set` inspection in DWDS (#2024)
>   442639d  2023-03-08  Elliott Brooks (she/her)  Handle unexpected extension debugger disconnection events without crashing app (#2021)
>
> yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3):
>   fbc5cb3  2023-03-09  Kevin Moore  Require Dart 2.19, update to latest lints
>   c9e82f0  2023-03-09  Mohamed Ishad  Fix YamlEditor.update method leaving trailing spaces at eol (#42)
>
> Change-Id: Idc785347448e6a56e26d9d46b3666440d59c22de
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288801
> Auto-Submit: Devon Carew <[email protected]>
> Reviewed-by: Konstantin Shcheglov <[email protected]>
> Commit-Queue: Konstantin Shcheglov <[email protected]>

Change-Id: If7dd2027f4b6ead777eaf1b3cf7561d4dced4095
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288802
Auto-Submit: Devon Carew <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 15, 2023
@devoncarew
[deps] rev args, benchmark_harness, csslib, dartdoc, http, shelf, web…
aab39d3 
…dev, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/9305d5a..7a5e3b0):
  7a5e3b0  2023-03-14  Devon Carew  update readme; add contributing doc (#237)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a6a0891..725534a):
  725534a  2023-03-14  Kevin Moore  Spelling fixes, latest lints, move to minilibs (drop parts) (#85)

csslib (https://github.com/dart-lang/csslib/compare/b671738..d32bdd4):
  d32bdd4  2023-03-14  Devon Carew  refactor the package example (#170)

dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4):
  7fde7a4d  2023-03-13  dependabot[bot]  Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363)

http (https://github.com/dart-lang/http/compare/805a147..74f9d3d):
  74f9d3d  2023-03-09  Brian Quinlan  Add conformances test that verify that the Client works in Isolates (#889)
  ee03604  2023-03-09  Brian Quinlan  Add a flag to allow the default Client to be tree shaken away. (#868)
  2039fb3  2023-03-09  Brian Quinlan  Fix a reference count race with forwarded delegates. (#888)

shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4):
  9a792b4  2023-03-13  Kevin Moore  Update format for latest v3 SDK (#340)
  c8094b7  2023-03-13  Kevin Moore  Update no-response.yml - once a day (#339)

webdev (https://github.com/dart-lang/webdev/compare/cfe9753..a15fde0):
  a15fde0  2023-03-15  Anna Gringauze  fix matching record types (#2032)
  05031da  2023-03-14  Anna Gringauze  Update build_daemon constraint and log errors (#2029)
  49013b8  2023-03-09  Elliott Brooks (she/her)  [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026)
  c8d4439  2023-03-09  Elliott Brooks (she/her)  Support `Set` inspection in DWDS (#2024)
  442639d  2023-03-08  Elliott Brooks (she/her)  Handle unexpected extension debugger disconnection events without crashing app (#2021)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3):
  fbc5cb3  2023-03-09  Kevin Moore  Require Dart 2.19, update to latest lints
  c9e82f0  2023-03-09  Mohamed Ishad  Fix YamlEditor.update method leaving trailing spaces at eol (#42)

Change-Id: Ia79a056cfaf7e51e73fdc6fd353e5f1938e6881a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289023
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 15, 2023
@a-siva
Revert "[deps] rev args, benchmark_harness, csslib, dartdoc, http, sh…
5f69a0c 
…elf, webdev, yaml_edit"

This reverts commit aab39d3.

Reason for revert: Failing some internal builds with the following error
http_client_conformance_tests: #wrong_required_libs #wrong_conditional_srcs
  "required_libs" is currently [] but the code imports ["isolate"].

Original change's description:
> [deps] rev args, benchmark_harness, csslib, dartdoc, http, shelf, webdev, yaml_edit
>
> Revisions updated by `dart tools/rev_sdk_deps.dart`.
>
> args (https://github.com/dart-lang/args/compare/9305d5a..7a5e3b0):
>   7a5e3b0  2023-03-14  Devon Carew  update readme; add contributing doc (#237)
>
> benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a6a0891..725534a):
>   725534a  2023-03-14  Kevin Moore  Spelling fixes, latest lints, move to minilibs (drop parts) (#85)
>
> csslib (https://github.com/dart-lang/csslib/compare/b671738..d32bdd4):
>   d32bdd4  2023-03-14  Devon Carew  refactor the package example (#170)
>
> dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4):
>   7fde7a4d  2023-03-13  dependabot[bot]  Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363)
>
> http (https://github.com/dart-lang/http/compare/805a147..74f9d3d):
>   74f9d3d  2023-03-09  Brian Quinlan  Add conformances test that verify that the Client works in Isolates (#889)
>   ee03604  2023-03-09  Brian Quinlan  Add a flag to allow the default Client to be tree shaken away. (#868)
>   2039fb3  2023-03-09  Brian Quinlan  Fix a reference count race with forwarded delegates. (#888)
>
> shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4):
>   9a792b4  2023-03-13  Kevin Moore  Update format for latest v3 SDK (#340)
>   c8094b7  2023-03-13  Kevin Moore  Update no-response.yml - once a day (#339)
>
> webdev (https://github.com/dart-lang/webdev/compare/cfe9753..a15fde0):
>   a15fde0  2023-03-15  Anna Gringauze  fix matching record types (#2032)
>   05031da  2023-03-14  Anna Gringauze  Update build_daemon constraint and log errors (#2029)
>   49013b8  2023-03-09  Elliott Brooks (she/her)  [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026)
>   c8d4439  2023-03-09  Elliott Brooks (she/her)  Support `Set` inspection in DWDS (#2024)
>   442639d  2023-03-08  Elliott Brooks (she/her)  Handle unexpected extension debugger disconnection events without crashing app (#2021)
>
> yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3):
>   fbc5cb3  2023-03-09  Kevin Moore  Require Dart 2.19, update to latest lints
>   c9e82f0  2023-03-09  Mohamed Ishad  Fix YamlEditor.update method leaving trailing spaces at eol (#42)
>
> Change-Id: Ia79a056cfaf7e51e73fdc6fd353e5f1938e6881a
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289023
> Reviewed-by: Konstantin Shcheglov <[email protected]>
> Commit-Queue: Konstantin Shcheglov <[email protected]>
> Auto-Submit: Devon Carew <[email protected]>

Change-Id: I07b1e6041babc92df359da89eb18c1daf2634d88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289024
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Siva Annamalai <[email protected]>
Reviewed-by: Ryan Macnak <[email protected]>
copybara-service bot pushed a commit that referenced this issue Mar 20, 2023
@devoncarew
[deps] rev args, benchmark_harness, clock, csslib, dartdoc, protobuf,…
c61241f 
… shelf, tools, vector_math, webdev, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (https://github.com/dart-lang/args/compare/9305d5a..7a5e3b0):
  7a5e3b0  2023-03-14  Devon Carew  update readme; add contributing doc (#237)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a6a0891..725534a):
  725534a  2023-03-14  Kevin Moore  Spelling fixes, latest lints, move to minilibs (drop parts) (#85)

clock (https://github.com/dart-lang/clock/compare/5abb481..984642e):
  984642e  2023-03-15  Kevin Moore  Require Dart 2.19, use and fix recommended lints (#46)

csslib (https://github.com/dart-lang/csslib/compare/b671738..d32bdd4):
  d32bdd4  2023-03-14  Devon Carew  refactor the package example (#170)

dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4):
  7fde7a4d  2023-03-13  dependabot[bot]  Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363)

protobuf (https://github.com/dart-lang/protobuf/compare/75bc380..b90a4c4):
  b90a4c4  2023-03-16  Mahdi K. Fard  Sort message constructors first. (#807)
  00fd975  2023-03-15  Kevin Moore  Fix formatting with latest SDK (#808)
  a67bbb3  2023-03-15  dependabot[bot]  Bump actions/cache from 3.2.4 to 3.2.6 (#804)

shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4):
  9a792b4  2023-03-13  Kevin Moore  Update format for latest v3 SDK (#340)
  c8094b7  2023-03-13  Kevin Moore  Update no-response.yml - once a day (#339)

tools (https://github.com/dart-lang/tools/compare/e5353aa..8d18d01):
  8d18d01  2023-03-15  Elias Yishak  Implement fake ga client (#37)

vector_math (https://github.com/google/vector_math.dart/compare/1e4d000..7dec984):
  7dec984  2023-03-16  eoineoineoin  Add operator== to Quaternion (#288)

webdev (https://github.com/dart-lang/webdev/compare/cfe9753..c2c8b17):
  c2c8b17  2023-03-16  Elliott Brooks (she/her)  Prepare Webdev version `3.0.2` for release (#2037)
  d124fa5  2023-03-16  Elliott Brooks (she/her)  Prepare extension for release (#2036)
  aef715d  2023-03-15  Elliott Brooks (she/her)  Prepare DWDS 18.0.1 for release (#2035)
  a15fde0  2023-03-15  Anna Gringauze  fix matching record types (#2032)
  05031da  2023-03-14  Anna Gringauze  Update build_daemon constraint and log errors (#2029)
  49013b8  2023-03-09  Elliott Brooks (she/her)  [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026)
  c8d4439  2023-03-09  Elliott Brooks (she/her)  Support `Set` inspection in DWDS (#2024)
  442639d  2023-03-08  Elliott Brooks (she/her)  Handle unexpected extension debugger disconnection events without crashing app (#2021)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3):
  fbc5cb3  2023-03-09  Kevin Moore  Require Dart 2.19, update to latest lints
  c9e82f0  2023-03-09  Mohamed Ishad  Fix YamlEditor.update method leaving trailing spaces at eol (#42)

Change-Id: Icf15fc0ffd3ee36e0380751d18fd491de071040e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289881
Auto-Submit: Devon Carew <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@madsager @DartBot