Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_assets_builder] Move packageLayout to builder constructor #1919

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

dcharkes
Copy link
Collaborator

All Dart and Flutter commands have a single package config and runPackageName.

Part of a larger refactoring that will make the NativeAssetsBuildRunner take more arguments in the constructor such as the package config, and reduces the number of arguments to the build and link methods.

This will enable:

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes dcharkes force-pushed the move-package-layout branch from f60591d to 45fbf4e Compare January 21, 2025 14:35
Base automatically changed from move-run-package to main January 21, 2025 14:45
@dcharkes dcharkes force-pushed the move-package-layout branch from 45fbf4e to 4e6f73a Compare January 21, 2025 14:46
@auto-submit auto-submit bot merged commit 3ed5d3d into main Jan 21, 2025
40 checks passed
@auto-submit auto-submit bot deleted the move-package-layout branch January 21, 2025 14:57
@coveralls
Copy link

Coverage Status

coverage: 88.557%. first build
when pulling 4e6f73a on move-package-layout
into b2ad4a8 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants