-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native_assets_builder] Support pub workspaces #1905
Milestone
Comments
For
Could this be changed to use |
Actually, we'd want to know where the package config is, because we want to build native assets next to it.
|
This was referenced Jan 17, 2025
auto-submit bot
pushed a commit
that referenced
this issue
Jan 21, 2025
…1919) All Dart and Flutter commands have a single package config and runPackageName. Part of a larger refactoring that will make the `NativeAssetsBuildRunner` take more arguments in the constructor such as the package config, and reduces the number of arguments to the `build` and `link` methods. This will enable: * Caching `BuildPlanner` logic (only one `runPackageName`) * Changing `packagesWithAssets` to take `runPackageName` into account (and possibly moving it to the native assets builder instead). #1905
We'll still need to roll this into Dart and Flutter. Keeping this open until that's done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The native assets builder should take into account pub workspaces:
.dart_tool/package_config.json
is to possibly be in a ancestor directoryrunPackageName
argument should be required for build/link hooks, so only native assets that are a dependency are built (instead of all packages in the package resolution of the whole workspace).runPackageName
argument should be required for "if there are packages with native assets", the native assets experiment only has to be enabled if a dependency has a hook.runPackageName
into theBuildInput
.And this needs to be rolled into
Yet another CI issue: Testing
native_assets_ci/example/build/native_dynamic_linking.dart
fails:PathNotFoundException: Cannot open file, path = 'D:\a\native\native\pkgs\native_assets_cli\example\build\native_add_app\.dart_tool\package_config.json' (OS Error: The system cannot find the file specified.
That's because the
native_assets_builder
package itself doesn't understand workspaces:Originally posted by @Levi-Lesches in #1884 (comment)
The text was updated successfully, but these errors were encountered: